Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some settings stay on after wipe until device is rebooted #1322

Closed
matejcik opened this issue Oct 22, 2020 · 2 comments · Fixed by #1328
Closed

some settings stay on after wipe until device is rebooted #1322

matejcik opened this issue Oct 22, 2020 · 2 comments · Fixed by #1328
Assignees
@matejcik
Labels
bug Something isn't working as expected core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Milestone
21.01

Comments

@matejcik
Copy link
Contributor

e.g., device rotation and auto-lock delay will stay with the same configuration, because the value is erased from storage but remains in effect in separate objects.

Ideal solution would be to reboot the device after wipe, but that is impractical from a technical standpoint.

As an interim solution, we could introduce something like apply_settings_from_storage() which would be called both at end of ApplySettings handler and WipeDevice handler
@matejcik matejcik added bug Something isn't working as expected core Trezor Core firmware. Runs on Trezor Model T and T2B1. S4 Low labels Oct 22, 2020
@matejcik
Copy link
Contributor Author

experimental flags are probably also affected

@matejcik matejcik self-assigned this Oct 22, 2020
matejcik added a commit that referenced this issue Oct 26, 2020
@matejcik
fix(core): make sure run-time settings are reset after wipe (fixes #1322
b119aac 
)
@tsusanka tsusanka added this to the 2020-11 milestone Oct 26, 2020
matejcik added a commit that referenced this issue Oct 26, 2020
@matejcik
fix(core): make sure run-time settings are reset after wipe (fixes #1322
c9af066 
)
matejcik added a commit that referenced this issue Oct 26, 2020
@matejcik
fix(core): make sure run-time settings are reset after wipe (fixes #1322
526d105 
)
matejcik added a commit that referenced this issue Oct 27, 2020
@matejcik
fix(core): make sure run-time settings are reset after wipe (fixes #1322
a1beaab 
)
matejcik added a commit that referenced this issue Oct 27, 2020
@matejcik
fix(core): make sure run-time settings are reset after wipe (fixes #1322
20ec6cc 
)
@matejcik matejcik mentioned this issue Oct 27, 2020
Merged
matejcik added a commit that referenced this issue Nov 5, 2020
@matejcik
fix(core): make sure run-time settings are reset after wipe (fixes #1322
6f36467 
)
matejcik added a commit that referenced this issue Nov 5, 2020
@matejcik
fix(core): make sure run-time settings are reset after wipe (fixes #1322
e83d548 
)
matejcik added a commit that referenced this issue Nov 5, 2020
@matejcik
fix(core): make sure run-time settings are reset after wipe (fixes #1322
37d3bf5 
)
@tsusanka tsusanka modified the milestones: 2020-11, 2020-12 Nov 6, 2020
@bosomt
Copy link

bosomt commented Dec 21, 2020

QA OK

i was not able to replicate it anymore, rotation and autolock is forgotten even when device is not reconnected

Nixos
Suite be4e3a36f7dbe15b2b203f66de11edc50a6665b8
Device: fw-regular-2.3.5-889a3699

@tsusanka tsusanka modified the milestones: 2020-12, 2021-01 Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejcik matejcik

Labels
bug Something isn't working as expected core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Projects
None yet
Milestone
21.01
Development

Successfully merging a pull request may close this issue.

make sure run-time settings are reset after wipe trezor/trezor-firmware
3 participants
@matejcik @tsusanka @bosomt