Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure run-time settings are reset after wipe #1328

Merged
merged 1 commit into from
Nov 5, 2020
Merged

make sure run-time settings are reset after wipe #1328

merged 1 commit into from
Nov 5, 2020
+43 −5

Conversation

matejcik
Copy link
Contributor

fixes #1322

@matejcik matejcik requested a review from tsusanka as a code owner October 27, 2020 13:16
@matejcik matejcik requested a review from mmilata October 27, 2020 13:16
@matejcik
Copy link
Contributor Author

todo: add changelog

mmilata
mmilata approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (edit: confirming screen rotation does not carry across individual test cases)

tsusanka
tsusanka approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@tsusanka tsusanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. I didn't test so I am not 100% sure we did not miss anything but nothing comes to my mind. So 👍

@matejcik matejcik force-pushed the matejcik/applysettings branch from 20ec6cc to 6f36467 Compare November 5, 2020 13:30
@matejcik matejcik force-pushed the matejcik/applysettings branch from 6f36467 to e83d548 Compare November 5, 2020 13:33
@matejcik matejcik merged commit 37d3bf5 into master Nov 5, 2020
@matejcik matejcik deleted the matejcik/applysettings branch November 5, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsusanka tsusanka tsusanka approved these changes

@mmilata mmilata mmilata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

some settings stay on after wipe until device is rebooted
3 participants
@matejcik @mmilata @tsusanka