Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typo in showing multisig XPUBS. #1431

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Conversation

andrewkozlik
Copy link
Contributor

Fixes a typo when showing XPUBs in multisig:

  • "others" = other people
  • "other's" = belonging to another person

Here we mean the second case.

[Not sure whether this passes CI tests. It's been 20 minutes, and I am still waiting for the CI to even start.]

@prusnak
Copy link
Member

prusnak commented Jan 25, 2021

I mean others as other XPUBs, but other's is slightly better.

Maybe we can use foreign instead?

Or switch to internal / external?

@andrewkozlik
Copy link
Contributor Author

Maybe we can use foreign instead?

Or switch to internal / external?

Those are all very good suggestions. I think both are better than other's. Based on the terminology used in Electrum, I would say that cosigner or cosigner's would also be a good option. Can't quite make up my mind.

@andrewkozlik andrewkozlik force-pushed the andrewkozlik/xpub-typo branch from c9d87ae to 6dba94b Compare January 26, 2021 12:29
@andrewkozlik
Copy link
Contributor Author

Based on internal poll I used cosigner. It would be slightly preferable to use cosigner's, but that doesn't fit well on the T2 screen.

@andrewkozlik andrewkozlik merged commit 79fad70 into master Jan 26, 2021
@andrewkozlik andrewkozlik deleted the andrewkozlik/xpub-typo branch January 26, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants