Fix of red screen #1676
Merged
Fix of red screen #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
reviewed
Jun 22, 2021
Comment on lines
+37
to
+44
| void shutdown(void) { | ||
| #ifdef USE_SVC_SHUTDOWN | ||
| svc_shutdown(); | ||
| #else | ||
| // It won't work properly unless called from the privileged mode | ||
| shutdown_privileged(); | ||
| #endif | ||
| } |
There was a problem hiding this comment.
Maybe we can use define instead of a function here.
But maybe that's over-optimizing stuff and compiler does this anyway ...
Suggested change
| void shutdown(void) { | |
| #ifdef USE_SVC_SHUTDOWN | |
| svc_shutdown(); | |
| #else | |
| // It won't work properly unless called from the privileged mode | |
| shutdown_privileged(); | |
| #endif | |
| } | |
| #ifdef USE_SVC_SHUTDOWN | |
| #define shutdown svc_shutdown | |
| #else | |
| // It won't work properly unless called from the privileged mode | |
| #define shutdown shutdown_privileged | |
| #endif |
There was a problem hiding this comment.
But maybe that's over-optimizing stuff and compiler does this anyway ...
Yes, compiler inlines it. I'd leave it as it is.
hiviah
approved these changes
Jun 22, 2021
prusnak
approved these changes
Jun 23, 2021
onvej-sl
force-pushed
the
onvej-sl/red_screen_fix
branch
from
f1c6cdc to
2c61e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1658.
From my point of view, the cause of the issue is that
shutdown()is called from the unprivileged mode (see this comment). To solve that, I implemented a SVC handler that callsshutdown()from the privileged mode.