Tweak validation of pre-authorized GetOwnershipProof #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pre-authorized GetOwnershipProof requests ensure that the commitment data starts with a length-prefixed name of the CoinJoin coordinator. [no changelog]
matejcik
approved these changes
Feb 11, 2022
onvej-sl
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1160 (comment).
This PR modifies the validation rules for pre-authorized
GetOwnershipProofmessages. Trezor will only check that commitment data starts with a length-prefixed name of the CoinJoin coordinator. The name can be followed by any other challenge that the coordinator chooses, typically a 32-byte round ID.