Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CoinJoin transaction checks #2180

Merged
merged 4 commits into from
Mar 17, 2022
Merged

Conversation

andrewkozlik
Copy link
Contributor

Closes #1160.

This PR implements the CoinJoin transaction checks that were agreed on in https://www.notion.so/satoshilabs/CoinJoin-checks-in-Trezor-35dfde067235476f945f7cec4173ff9b (see the items highlighted in green).

@andrewkozlik andrewkozlik added core Trezor Core firmware. Runs on Trezor Model T and T2B1. bitcoin Bitcoin related R&D Research and development team related labels Mar 16, 2022
@andrewkozlik andrewkozlik requested a review from matejcik as a code owner March 16, 2022 13:12
Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK structurally, cannot comment on the business logic part

common/protob/messages-bitcoin.proto Outdated Show resolved Hide resolved
core/src/apps/bitcoin/authorize_coinjoin.py Outdated Show resolved Hide resolved
@andrewkozlik andrewkozlik force-pushed the andrewkozlik/coinjoin-checks branch from 649c072 to 32ad533 Compare March 17, 2022 08:30
@andrewkozlik andrewkozlik force-pushed the andrewkozlik/coinjoin-checks branch from 32ad533 to b69549e Compare March 17, 2022 10:05
@andrewkozlik andrewkozlik merged commit 9e346b0 into master Mar 17, 2022
@andrewkozlik andrewkozlik deleted the andrewkozlik/coinjoin-checks branch March 17, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitcoin Bitcoin related core Trezor Core firmware. Runs on Trezor Model T and T2B1. R&D Research and development team related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak CoinJoin transaction checks
3 participants