feat: show fee rate when signing transaction

[marnova]

Resolves issue #1294

[prusnak]

Can you please post before and after screenshots from emulators so we see how the new screens look like?

Also it would be helpful, if you set the fee to some custom value in the Suite (e.g. 3 sat/vbyte) and show the value is shown the same in the Suite and on the device?

[matejcik]

note, CI will generate screenshot diff as soon as device tests pass

[marnova]

@prusnak @matejcik
Screenshots are generated even though core device test failed:

1. summary for TT is e.g. here for last pipeline (diffs in screens are best visible in the failed tests),
2. and for T1 summary could be found here and one example of recorded screen with fee rate here.

Will try it with Suite+emulator later today/tomorrow.

[matejcik]

@marnova please fix the tests that are still failing

[bosomt]

QA OK

a1d2289
trezor-fw-regular-2.5.1-a1d22890.bin
trezor-fw-regular-1.11.1-a1d22890.bin

[marnova]

@prusnak @matejcik

• T1

---

• TT

[mmilata]

UI diff shows nothing due to #2285. For e3f46f4 you can see it here: https://satoshilabs.gitlab.io/-/trezor/trezor-firmware/-/jobs/2500213083/artifacts/master_diff/index.html

[matejcik]

picked one at random -- this does not look right https://satoshilabs.gitlab.io/-/trezor/trezor-firmware/-/jobs/2500213083/artifacts/master_diff/diff/T1_bitcoin-test_signtx_replacement.py::test_p2tr_invalid_signature.html
any idea @marnova ?

[marnova]

@matejcik
Not sure whether those differences are valid. The one you linked shows (for that particular test), that my branch has hash 1f46b6ec89be1742dc4649153e6d13b172c9e93be7c91063650f814e631b757c - but that's not true - see here

trezor-firmware/tests/ui_tests/fixtures.json

Line 279 in e3f46f4

"T1_bitcoin-test_signtx_replacement.py::test_p2tr_invalid_signature": "00f4f745f88f1072f495e513d6a7747db494bb7c785c32d167652fe1d79509be",

Also the latest pipeline on Gitlab shows different screens - https://satoshilabs.gitlab.io/-/trezor/trezor-firmware/-/jobs/2497157113/artifacts/test_ui_report/passed/T1_bitcoin-test_signtx_replacement.py::test_p2tr_invalid_signature.html

@mmilata could be that the script has other bug(s)? Or it compared screens with different commit (even though I'm not aware that I would remove any screen completely)?

[mmilata]

My bad, I forgot to git fetch and the report I posted is actually for 828de33. #2285 is merged, you can rebase on top of master now to get the up to date report.

[matejcik]

@bosomt can you please test this with DOGE where fees are very large (last time I checked)?

[bosomt]

@matejcik DOGE fees are already changed.
Suite and TT are reporting same fee rate Fee rate 1000 sat/B or 1000.0 sat/vB
When i try to set it manually to 6555555.99 sat/B they are displayed correctly
/except that device only shows6555555.00 sat/B but it's known issue /