feat(cardano): add support for CIP-36 governance registration format #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejcik
approved these changes
Oct 19, 2022
davidmisiak
force-pushed
the
cardano-governance-cip36
branch
from
6994d3f to
fe78d0c
Compare
davidmisiak
force-pushed
the
cardano-governance-cip36
branch
from
fe78d0c to
e57e42e
Compare
Done, UI tests should be up to date. I also added changelog entries and rebased. |
|
Also @matejcik, here is a commit that adds new testnets. Should I add it here or open a separate PR? |
|
feel free to add here. it has no effect on tests, right? |
I believe so. Thanks, added. |
|
Hi @matejcik, is there a chance we could merge this before the FW freeze please? |
|
that is the plan, yes |
|
will be merged in #2591 |
|
Awesome, thanks! |
This was referenced Nov 1, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for CIP-36 governance registration format. Changes:
delegationsarray (each delegation consists of a voting key and its voting power proportion) as an alternative to delegating the entire voting power to a single voting key. The array is embedded in the protobuf message due to simplicity (max. 32 delegations allowed).voting_purposeinteger (currently 0 = Catalyst, 1 = other). In CIP-36 registrations, this field is always serialized, (value 0 is used if not provided by the client).Catalystoccurences are replaced bygovernance, since the format should be usable for other governance purposes, not only Catalyst.ed25519_pkbech32 prefix is replaced bygov_vkfor the purpose of displaying voting public keys.The new 1694' derivation path and the vote cast call implementation is not included in this PR.
EDIT - Added:
cardanoctl.