Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETH fees units #3246

Closed
Hannsek opened this issue Sep 4, 2023 · 2 comments · Fixed by #3414
Closed

ETH fees units #3246

Hannsek opened this issue Sep 4, 2023 · 2 comments · Fixed by #3414
Assignees
@grdddj
Labels
altcoin Any non-Bitcoin coins
Milestone
Firmware 2.6.3 re...

Comments

@Hannsek
Copy link
Contributor

Hannsek commented Sep 4, 2023

Please change ETH fees units in ETH send flow as follows:
image
image

Maximum fee: wei ETH -> ETH
Gas price: ETH -> Gwei

Add (if not already satisfied) priority fee key.
@Hannsek Hannsek added the altcoin Any non-Bitcoin coins label Sep 4, 2023
@Hannsek Hannsek added this to Firmware Sep 4, 2023
@Hannsek Hannsek moved this to 🎯 To do in Firmware Sep 4, 2023
@Hannsek Hannsek added this to the Firmware 2.6.1 release milestone Sep 4, 2023
@Hannsek Hannsek removed the status in Firmware Sep 11, 2023
@Hannsek Hannsek moved this to 🎯 To do in Firmware Sep 14, 2023
@grdddj grdddj moved this from 🎯 To do to 🏃‍♀️ In progress in Firmware Oct 23, 2023
@grdddj grdddj moved this from 🏃‍♀️ In progress to 🎯 To do in Firmware Oct 30, 2023
@Hannsek
Copy link
Contributor Author

Hannsek commented Nov 22, 2023

@grdddj please take a look, it should be low hanging.

@grdddj grdddj mentioned this issue Nov 22, 2023
Merged
@grdddj
Copy link
Contributor

grdddj commented Nov 22, 2023

@grdddj please take a look, it should be low hanging.

Right, PR done - #3414

It was quite easy to change, but I am not sure we want it like this --- please check the results/diffs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grdddj grdddj

Labels
altcoin Any non-Bitcoin coins
Projects
Firmware
Archived in project
Milestone
Firmware 2.6.3 release
Development

Successfully merging a pull request may close this issue.

chore(core): hardcode ETH and Gwei units in ETH send summary trezor/trezor-firmware
2 participants
@grdddj @Hannsek