chore(core): hardcode ETH and Gwei units in ETH send summary

[grdddj]

Fixes #3246:

• enforces usage of certain units in ETH summary - ETH for amount and total fee, Gwei ETH for the rest.

Not sure, however, that we want to force it, as there are these cases where a very small value gets displayed in a very big unit. Previously, the code was checking this --- either showing ETH if the value was bigger than 10 ^ 9 and wei ETH otherwise.

[Hannsek]

Ahhh, ok, it cannot be like that :(
For Maximum fee and Amount please revert the changes.

Gwei ETH for the rest.

We should use only Gwei/Wei (without ETH) for gas limit a and priority fee.

[matejcik]

i think we just need to touch the "10^9" number -- so that we get at most, say, 10 decimals?

[grdddj]

Ahhh, ok, it cannot be like that :( For Maximum fee and Amount please revert the changes.

Gwei ETH for the rest.

We should use only Gwei/Wei (without ETH) for gas limit a and priority fee.

Reverted and changed in b428d53

[grdddj]

i think we just need to touch the "10^9" number -- so that we get at most, say, 10 decimals?

Not sure what are the requirements ... but we have good unittests for this function, feel free to suggest some new behavior

https://github.com/trezor/trezor-firmware/blob/main/core/tests/test_apps.ethereum.layout.py

There are some edge-cases like this, where there will be much more than 10 valid digits:

text = format_ethereum_amount(1000000000000000001, None, ETH)
self.assertEqual(text, "1.000000000000000001 ETH")

@Hannsek - a general question, who is wanting these changes?

[Hannsek]

It's me. Our fee units are not standard.

It should look like this:

[grdddj]

It's me. Our fee units are not standard.

It should look like this:

Should be the case now. Priority fee is only shown in eip1559, which looks like we have test-screens only for TR

[Hannsek]

Why do we have max gas price on T2B1 and gas price on TT? We should have it the same on both devices. Please use only gas price.

[grdddj]

Why do we have max gas price on T2B1 and gas price on TT? We should have it the same on both devices. Please use only gas price.

That is not the difference between models, but between 1559 and normal signing. All these texts are the same for both devices