-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIN verification using Optiga #3296
Conversation
0478258
to
a19732d
Compare
05ef0d0
to
b830e3b
Compare
@onvej-sl has reviewed the cryptographic solution and will do a final check tomorrow. I would like another set of eyes to go over the code, @matejcik please. I am hoping to get this merged tomorrow. The reason why it is in draft form is because it's branched off of the hashing-to-curve PR, which is not merged yet. |
2aa7bfb
to
d60e9a5
Compare
f89b889
to
4c144cd
Compare
5d79134
to
121a16d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code-wise, except the progess(0)
thing you discovered
Should be fixed by 38b331d |
96e9912
to
64a8fc3
Compare
Creating this draft PR, so we can start discussion about the cryptographic aspects of the PIN verification process using Optiga. @onvej-sl
I did some refactoring around the
ui_progress
, which as it turns out is not really necessary, since we decided to setPIN_STRETCH_ITERATIONS
to 1, so it takes no noticeable time (unless the security monitor kicks in). But I think the refactor still has some value, so I decided to keep it. It might be used in optiga.c in the future if we have our own configuration of the security monitor which will allow us to increasePIN_STRETCH_ITERATIONS
. For now I removed some of the unused code in a separate commit, so that it can be reverted when the time comes.