fix(solana): fix Memo, multisig and polish instructions UI #3445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For receiving to a multisig address, users should see this screen: |
gabrielKerekes
force-pushed
the
fix/solana-memo-and-multisig
branch
from
dd9e319 to
bcaa944
Compare
|
@gabrielKerekes Please post here the UI changes. |
We're currently not optimising the UI for general instructions.
Will try. |
|
Hopefully this will help you - the |
|
all seems good in CI, please add changelog (since this is going out in the next release so it's a change) |
matejcik
approved these changes
Dec 11, 2023
|
👋 Will there be a FW release this month or when can we expect this to be released? 🙏 |
|
Next release will happen together with March release of Suite -> 13.3. (EAP) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two important issues with Solana, one medium issue and minor issues with the way some instructions are displayed:
Memo instruction is currently treated as an uknown instruction i.e. it's basically being blind signed.
Multisig token transfer instruction is also treated as a predefined instruction and multisig signers are not shown. The only warning the user getting that it's a multisig instruction is the
Transaction requires X signers which increases the fee.warning.The
The following instruction is a multisig instruction.message is shown after the instruction parameters are shown but before the accounts - it should be displayed even before the parameters.The order in which some properties are displayed has been changed and the wording of some of the properties has been updated.
Note: I would have regenerated the UI fixtures but I get different results for all of them although definitely not all of them should've changed. Not sure what's going on here. This happens for both Trezor T and R, I run the T emulator with the
-aswitch to stop animation.