-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cardano: Conway certificates and tagged sets #3496
Cardano: Conway certificates and tagged sets #3496
Conversation
9846b99
to
d8922c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code content ACK. please do the following to get up-to-date:
- rebase on current main
- regenerate UI fixtures for TT and TR
- force-push the code
- add
translations
label to the PR - when the CI is done, run
./tests/update_fixtures.py ci
and./tests/update_fixtures.py ci --github
- commit the changes in a fixup
- check that the CI now passes
one or more steps may fail because you are an external contributor, i'll try to follow up
d8922c3
to
7cd8dad
Compare
Hi, I rebased and added the translations. Unfortunately, I cannot add the label, and CI has not started it seems. #3509 is in a similar state. |
you should now be able to run i'll repush the branch so that gitlab runs it |
Pushed changes from |
try also |
I'm getting this (with no changes in
By the way, what's the difference between the github and gitlab pipeline? |
practically speaking, gitlab also runs T2B1 click tests which are broken in github. |
please squash the fixup so I can merge |
9ca2c8d
to
ad9b6e7
Compare
Squashed |
Update with select Cardano Conway features:
Resources:
https://github.com/IntersectMBO/cardano-ledger/blob/master/eras/conway/impl/cddl-files/conway.cddl
https://github.com/cardano-foundation/CIPs/tree/master/CIP-0005
https://github.com/cardano-foundation/CIPs/tree/master/CIP-1694
https://sancho.network/tools-resources/faq/#4-certificate-and-transaction-field-witnesses-and-deposits