Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardano: Conway certificates and tagged sets #3496

Merged
merged 5 commits into from
May 23, 2024

Conversation

jaskp
Copy link
Contributor

@jaskp jaskp commented Jan 18, 2024

Update with select Cardano Conway features:

  • Transactions with new stake registration and deregistration certificates and a DRep vote delegation certificate (does not include any new key derivations nor voting procedures)
  • Flag that globally sets the CBOR encoding of "sets" to include the 258 tag. Without it, "sets" are just plain CBOR arrays.
  • Increase of URL length limit from 64 to 128 bytes

Resources:
https://github.com/IntersectMBO/cardano-ledger/blob/master/eras/conway/impl/cddl-files/conway.cddl
https://github.com/cardano-foundation/CIPs/tree/master/CIP-0005
https://github.com/cardano-foundation/CIPs/tree/master/CIP-1694
https://sancho.network/tools-resources/faq/#4-certificate-and-transaction-field-witnesses-and-deposits

Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code content ACK. please do the following to get up-to-date:

  1. rebase on current main
  2. regenerate UI fixtures for TT and TR
  3. force-push the code
  4. add translations label to the PR
  5. when the CI is done, run ./tests/update_fixtures.py ci and ./tests/update_fixtures.py ci --github
  6. commit the changes in a fixup
  7. check that the CI now passes

one or more steps may fail because you are an external contributor, i'll try to follow up

@davidmisiak davidmisiak force-pushed the feat/cardano/conway/stake-certs branch from d8922c3 to 7cd8dad Compare May 16, 2024 22:08
@davidmisiak davidmisiak requested a review from prusnak as a code owner May 16, 2024 22:08
@davidmisiak
Copy link
Contributor

Hi, I rebased and added the translations. Unfortunately, I cannot add the label, and CI has not started it seems.

#3509 is in a similar state.

@matejcik matejcik added the translations Put this label on a PR to run tests in all languages label May 17, 2024
@matejcik
Copy link
Contributor

you should now be able to run update_fixtures.py ci --github

i'll repush the branch so that gitlab runs it

@davidmisiak
Copy link
Contributor

Pushed changes from update_fixtures.py ci --github.

@matejcik
Copy link
Contributor

try also update_fixtures.py ci without --github, i think the gitlab pipeline is done too

@davidmisiak
Copy link
Contributor

I'm getting this (with no changes in fixtures.json):

❯ ./tests/update_fixtures.py ci
Updating from CI...
Branch: feat/cardano/conway/stake-certs
Checking branch feat/cardano/conway/stake-certs
Checking job core click R test
Checking job core click test
Checking job core device R test
Checking job core device test
Checking job core persistence test
No results yet.
Checking job legacy device test
Updating results from core click R test...
Updated 0 tests.
Updating results from core click test...
Updated 0 tests.
Updating results from core device R test...
Updated 0 tests.
Updating results from core device test...
Updated 0 tests.
Updating results from core persistence test...
Updated 0 tests.
Updating results from legacy device test...
Updated 0 tests.
--------------------------------------------------------------------------------
Updated 0 tests in total.
Updated fixtures.json with data from CI.

By the way, what's the difference between the github and gitlab pipeline?

@matejcik
Copy link
Contributor

By the way, what's the difference between the github and gitlab pipeline?

practically speaking, gitlab also runs T2B1 click tests which are broken in github.
(well they're broken mostly everywhere but they work on gitlab so we keep it around)
with that said I believe that you're not touching click tests so we don't expect failures there.

@matejcik
Copy link
Contributor

please squash the fixup so I can merge

@davidmisiak davidmisiak force-pushed the feat/cardano/conway/stake-certs branch from 9ca2c8d to ad9b6e7 Compare May 22, 2024 14:58
@davidmisiak
Copy link
Contributor

Squashed

@matejcik matejcik merged commit 2b54580 into trezor:main May 23, 2024
105 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Put this label on a PR to run tests in all languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants