-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/emu): handle arrow buttons as swipes #3619
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obrusvit
added
the
emulator only
Issue which does not appear on the physical device - but on emulator only.
label
Mar 17, 2024
I believe it should be vice versa. When you want to swipe up, you should use down arrow. |
obrusvit
force-pushed
the
obrusvit/sim-use-arrow-as-swipe
branch
2 times, most recently
from
March 20, 2024 11:32
ef4db2d
to
9ca45d0
Compare
Updated based on comments AFK:
|
cepetr
requested changes
Mar 20, 2024
|
cepetr
reviewed
Mar 21, 2024
cepetr
approved these changes
Mar 21, 2024
obrusvit
force-pushed
the
obrusvit/sim-use-arrow-as-swipe
branch
from
March 21, 2024 10:39
bedeb8a
to
29d192a
Compare
[no changelog]
obrusvit
force-pushed
the
obrusvit/sim-use-arrow-as-swipe
branch
from
March 21, 2024 10:45
29d192a
to
adcb613
Compare
QA OK Info:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds capability to perform swipe gestures using arrow keys for touch models.
Current implementation. Arrow key dictates direction of swipe.
I can switch it up but it depends on what's more useful.