Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): add ability to set up a device with SLIP39 "single" #3899

Merged
merged 3 commits into from
Jun 5, 2024
Merged

chore(core): add ability to set up a device with SLIP39 "single" #3899

merged 3 commits into from
Jun 5, 2024

Conversation

ibz
Copy link
Contributor

@ibz ibz commented Jun 5, 2024

No description provided.

@ibz ibz self-assigned this Jun 5, 2024
@ibz ibz requested a review from matejcik as a code owner June 5, 2024 11:06
@ibz ibz force-pushed the ibz/20240605-param branch from 5054a02 to ff242e9 Compare June 5, 2024 11:09
@matejcik
Copy link
Contributor

matejcik commented Jun 5, 2024

it's a chore for python not core

@matejcik
Copy link
Contributor

matejcik commented Jun 5, 2024

honestly maybe more of a feat

@ibz ibz force-pushed the ibz/20240605-param branch 3 times, most recently from 3c37149 to 5aacb83 Compare June 5, 2024 11:32
@ibz ibz force-pushed the ibz/20240605-param branch 2 times, most recently from 26c3b24 to 8b6be2a Compare June 5, 2024 13:56
@ibz ibz requested a review from andrewkozlik as a code owner June 5, 2024 13:56
@matejcik matejcik force-pushed the ibz/20240605-param branch from 8b6be2a to ff7744e Compare June 5, 2024 16:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T2B1 Safe 3 3280 test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@obrusvit obrusvit added this to the PR run languages milestone Jun 5, 2024
@matejcik matejcik force-pushed the ibz/20240605-param branch from 60363c9 to 038f710 Compare June 5, 2024 19:40
@matejcik matejcik requested review from onvej-sl and prusnak as code owners June 5, 2024 19:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024 •
edited
Loading

legacy UI changes device test(screens) main(screens)

@matejcik matejcik changed the base branch from main to PR-UI-LANGUAGES June 5, 2024 19:41
ibz and others added 3 commits June 5, 2024 22:38
@matejcik matejcik force-pushed the ibz/20240605-param branch from 038f710 to a7850bd Compare June 5, 2024 20:45
@matejcik matejcik merged commit dc4b08b into PR-UI-LANGUAGES Jun 5, 2024
36 of 38 checks passed
@matejcik matejcik deleted the ibz/20240605-param branch June 5, 2024 20:46
@ibz ibz linked an issue Jun 11, 2024 that may be closed by this pull request
Better integration of Slip39_Single backup type #3868
Closed
4 tasks
@STew790
Copy link

STew790 commented Jun 13, 2024

QA OK
Done together with Suite https://www.notion.so/satoshilabs/Creating-new-multishare-backup-testing-activity-ab3a703401f344dab67537ecb327acf0

Info:

  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: Trezor T3T1 2.7.2 regular (revision da75d8f)
  • Transport: BridgeTransport 2.0.33

@STew790 STew790 mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejcik matejcik matejcik left review comments

@mmilata mmilata mmilata approved these changes

@andrewkozlik andrewkozlik Awaiting requested review from andrewkozlik

@onvej-sl onvej-sl Awaiting requested review from onvej-sl

@prusnak prusnak Awaiting requested review from prusnak

Assignees

@ibz ibz

Labels
None yet
Projects
Firmware
Archived in project
Milestone
PR run languages
Development

Successfully merging this pull request may close these issues.

Better integration of Slip39_Single backup type
5 participants
@ibz @matejcik @STew790 @mmilata @obrusvit