Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): TS3 device freeze #3925

Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix(core): TS3 device freeze #3925

merged 1 commit into from
Jun 7, 2024

Conversation

matejcik
Copy link
Contributor

@matejcik matejcik commented Jun 7, 2024

some things about Rusty button requests were mishandled on the TR part. This PR brings it all (hopefully) up to spec.

mmilata
mmilata approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What to say, this should have been in the original PR.

@matejcik matejcik merged commit b560ce5 into main Jun 7, 2024
79 of 80 checks passed
@matejcik matejcik deleted the obrusvit/ts3-freeze-fix-attempt branch June 7, 2024 12:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T2B1 Safe 3 test(screens) main(screens) test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@mmilata mmilata mentioned this pull request Jun 7, 2024
Merged
@bosomt
Copy link

bosomt commented Jun 9, 2024

QA OK

Info:

  • Suite version: desktop 24.6.1 (ee1bf19e747daba31bec272b64d09bfa8c6a807e)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.6.1 Chrome/118.0.5993.159 Electron/27.3.8 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.7.2 regular (revision e90cf36)
  • Transport: BridgeTransport 2.0.33

@mmilata mmilata mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matejcik @bosomt @mmilata @obrusvit