Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe tuning #3965

Merged
merged 10 commits into from
Jul 1, 2024
Merged

Swipe tuning #3965

merged 10 commits into from
Jul 1, 2024

Conversation

TychoVrahe
Copy link
Contributor

@TychoVrahe TychoVrahe commented Jun 19, 2024

This PR addresses several problems/UX issues with swiping on T3T1.

  • when changing layout (with going through python), swipe direction is remembered and therefore the second part of the animation has right effect
  • no longer blocking swipes when button is pressed, rather we selectively block swipes on hold to confirm press only. When the swipe is locked-in while, new TouchAbort event is sent so any pressed buttons are deactivated.
  • swipes beginning too close to an edge (that in direction of the swipe) are ignored, as they would fail anyway
  • handling of repeated touches when swiping is improved
  • instant lock-trigger of swipe without TouchMove event in between Start and End is removed- this would cause some complications with the new TouchAbort mechanism and these situations are not real swipes anyway..
  • hold to confirm screen when showing share words is animated
  • internal swipes handling is improved - when entering/exiting screen with internal swipes, normal swipe animation is played. This mainly affects show share words flow.
  • duration of canceled swipe animation is fixed

Also in this PR, a fix of two other bugs:

  • touch driver sometimes issued second TouchStart/End event pair, causing double button clicks for example
  • backlight handling on first paint is fixed to address now quicker timers when playing attach animation

@TychoVrahe TychoVrahe self-assigned this Jun 19, 2024
@TychoVrahe TychoVrahe force-pushed the tychovrahe/ui-t3t1/backlight branch from 94cbb54 to 53e3a34 Compare June 19, 2024 20:11
Copy link

github-actions bot commented Jun 19, 2024

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T2B1 Safe 3 test(screens) main(screens) test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@TychoVrahe TychoVrahe force-pushed the tychovrahe/ui-t3t1/backlight branch from d75fc30 to 967b81c Compare June 20, 2024 10:40
@TychoVrahe TychoVrahe marked this pull request as ready for review June 20, 2024 10:40
@TychoVrahe TychoVrahe requested review from mmilata and cepetr and removed request for prusnak June 20, 2024 10:40
@TychoVrahe
Copy link
Contributor Author

@cepetr please see 967b81c (we already discussed this)

@matejcik please review 48966be

Copy link
Contributor

@cepetr cepetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked just at 967b81c and utACK.

core/embed/rust/src/ui/layout/obj.rs Outdated Show resolved Hide resolved
core/src/trezor/ui/layouts/common.py Outdated Show resolved Hide resolved
core/src/trezor/ui/layouts/tt/__init__.py Outdated Show resolved Hide resolved
core/embed/rust/src/ui/model_mercury/layout.rs Outdated Show resolved Hide resolved
core/embed/rust/src/ui/event.rs Outdated Show resolved Hide resolved
core/embed/rust/src/ui/event.rs Outdated Show resolved Hide resolved
@matejcik matejcik added this to the June release milestone Jun 25, 2024
Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code ACK but we're out of flash again :(

@TychoVrahe TychoVrahe force-pushed the tychovrahe/ui-t3t1/backlight branch 2 times, most recently from 87aa461 to 93df60b Compare June 26, 2024 10:23
@matejcik matejcik force-pushed the tychovrahe/ui-t3t1/backlight branch from 93df60b to d1d64f2 Compare June 30, 2024 13:50
@TychoVrahe TychoVrahe linked an issue Jun 30, 2024 that may be closed by this pull request
@TychoVrahe TychoVrahe force-pushed the tychovrahe/ui-t3t1/backlight branch from 6890343 to ae4a8f8 Compare July 1, 2024 06:07
@matejcik matejcik merged commit b420016 into main Jul 1, 2024
79 of 83 checks passed
@matejcik matejcik deleted the tychovrahe/ui-t3t1/backlight branch July 1, 2024 07:33
@bosomt
Copy link

bosomt commented Jul 1, 2024

QA OK

  • Device: Trezor T3T1 2.8.0 regular (revision dd4671a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Touches are represented as double touch most of times
4 participants