-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swipe tuning #3965
Merged
Merged
Swipe tuning #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/backlight
branch
from
June 19, 2024 20:11
94cbb54
to
53e3a34
Compare
|
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/backlight
branch
from
June 20, 2024 10:40
d75fc30
to
967b81c
Compare
TychoVrahe
requested review from
mmilata and
cepetr
and removed request for
prusnak
June 20, 2024 10:40
cepetr
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked just at 967b81c and utACK.
matejcik
reviewed
Jun 24, 2024
matejcik
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code ACK but we're out of flash again :(
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/backlight
branch
2 times, most recently
from
June 26, 2024 10:23
87aa461
to
93df60b
Compare
…ition through python
… swipe lock instead
…edge of the display
…ay while the transition is already in effect
matejcik
force-pushed
the
tychovrahe/ui-t3t1/backlight
branch
from
June 30, 2024 13:50
93df60b
to
d1d64f2
Compare
TychoVrahe
force-pushed
the
tychovrahe/ui-t3t1/backlight
branch
from
July 1, 2024 06:07
6890343
to
ae4a8f8
Compare
QA OK
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several problems/UX issues with swiping on T3T1.
Also in this PR, a fix of two other bugs: