Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T3T1 UI: FIDO2 flow #4069

Merged
merged 4 commits into from
Sep 2, 2024
Merged

T3T1 UI: FIDO2 flow #4069

merged 4 commits into from
Sep 2, 2024

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Jul 29, 2024 •
edited
Loading

emu00000000 emu00000000 emu00000001 emu00000002 emu00000001 emu00000002

Fixes: #3797, Figma

Submodule dependencies: trezor/fido2-tests#4

@mmilata mmilata force-pushed the mmilata/ui-t3t1-fido2 branch from c5aecd9 to 962d6fc Compare July 30, 2024 15:36
@obrusvit obrusvit mentioned this pull request Aug 15, 2024
Merged
@mmilata mmilata force-pushed the mmilata/ui-t3t1-fido2 branch 6 times, most recently from 80efd33 to 0b867b3 Compare August 26, 2024 14:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T2B1 Safe 3 test(screens) main(screens) test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@mmilata mmilata force-pushed the mmilata/ui-t3t1-fido2 branch from 37b9dee to 8648ba0 Compare August 26, 2024 16:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

legacy UI changes device test(screens) main(screens)

@mmilata mmilata force-pushed the mmilata/ui-t3t1-fido2 branch from 1a001f8 to fd9dfb2 Compare August 26, 2024 20:39
@mmilata mmilata mentioned this pull request Aug 26, 2024
Merged
@mmilata mmilata force-pushed the mmilata/ui-t3t1-fido2 branch from fd9dfb2 to 1bb8083 Compare August 26, 2024 21:08
@mmilata mmilata marked this pull request as ready for review August 26, 2024 21:08
@mmilata mmilata requested review from ibz and obrusvit and removed request for prusnak and matejcik August 26, 2024 21:09
@mmilata mmilata self-assigned this Aug 26, 2024
@mmilata mmilata added fido Two-factor authentication using Trezor T3T1 Trezor Safe 5 labels Aug 26, 2024
@mmilata
Copy link
Member Author

mmilata commented Aug 26, 2024

cc @lapohoda

obrusvit
obrusvit reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the layouts, in the meantime:
trezorctl fido credentials list does not have a PromptScreen when confirming export

@mmilata mmilata requested a review from andrewkozlik as a code owner August 29, 2024 11:54
@mmilata mmilata force-pushed the mmilata/ui-t3t1-fido2 branch from 8e86ce4 to c185cb4 Compare August 29, 2024 14:47
@mmilata mmilata added the translations Put this label on a PR to run tests in all languages label Aug 29, 2024
@mmilata mmilata force-pushed the mmilata/ui-t3t1-fido2 branch from c185cb4 to c34de1a Compare September 2, 2024 14:18
@mmilata mmilata merged commit 7db1529 into main Sep 2, 2024
119 of 121 checks passed
@mmilata mmilata deleted the mmilata/ui-t3t1-fido2 branch September 2, 2024 17:36
@bosomt
Copy link

bosomt commented Sep 4, 2024

QA OK

  • Device: Trezor T3T1 2.8.2 regular (revision d7e1f0f)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obrusvit obrusvit obrusvit approved these changes

@ibz ibz Awaiting requested review from ibz

@andrewkozlik andrewkozlik Awaiting requested review from andrewkozlik andrewkozlik is a code owner

Assignees

@mmilata mmilata

Labels
fido Two-factor authentication using Trezor T3T1 Trezor Safe 5 translations Put this label on a PR to run tests in all languages
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FIDO flow
3 participants
@mmilata @bosomt @obrusvit