Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove system popup informing about unknown host from request filter #4684

Closed
3 of 4 tasks
hynek-jina opened this issue Dec 22, 2021 · 3 comments
Closed
3 of 4 tasks

Remove system popup informing about unknown host from request filter #4684

hynek-jina opened this issue Dec 22, 2021 · 3 comments
Assignees
@marekrjpolak
Labels
code Code improvements

Comments

@hynek-jina
Copy link
Contributor

hynek-jina commented Dec 22, 2021 •
edited by matejkriz
Loading

  • Stop following HTTP redirects (needs investigation)
  • Start reporting to Sentry all attempts to fetch domains that are not whitelisted
  • Remove confusing and ugly system popup warning for blocked domains
  • Give the user the option to allow fetch on domain that is not whitelisted (needed for AOPP?)
@hynek-jina hynek-jina added the code Code improvements label Dec 22, 2021
@matejkriz
Copy link
Member

the last point Give the user the option to allow fetch on domain that is not whitelisted (needed for AOPP?) is done in #4512

@matejkriz matejkriz added HIGH and removed MEDIUM labels Feb 3, 2022
@matejkriz matejkriz changed the title Suite web redirects Remove system popup informing about unknown host from request filter Feb 4, 2022
@marekrjpolak marekrjpolak mentioned this issue Feb 4, 2022
Merged
@hynek-jina hynek-jina moved this to 🔥 Priority in Issues Suite Feb 9, 2022
@matejkriz
Copy link
Member

System popup warning for blocked domains has been removed and instead it's reported to Sentry.

@STew790
Copy link
Contributor

STew790 commented Feb 25, 2022

QA OK

No warning appeared in Suite, only error in console and a report to sentry.

image

https://sentry.io/share/issue/4fbbb8adc14f424288445f707479aee3/

Info:

  • Suite version: desktop 22.3.0 (3041e4c)
  • Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/22.3.0 Chrome/94.0.4606.81 Electron/15.3.0 Safari/537.36
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: model T 2.4.3 regular

@hynek-jina hynek-jina moved this from 🔥 Priority to ✅ Approved in Issues Suite Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marekrjpolak marekrjpolak

Labels
code Code improvements
Projects
Issues Suite
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@matejkriz @hynek-jina @marekrjpolak @STew790