Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentry in electron #4853

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Sentry in electron #4853

merged 3 commits into from
Feb 25, 2022

Conversation

marekrjpolak
Copy link
Contributor

@marekrjpolak marekrjpolak commented Feb 4, 2022 •
edited
Loading

929c258 - removes allow/deny dialog from electron app when requesting unknown hostnames completely, as it's not needed anymore (part of #4684).
5f79bdb - use only @sentry/minimal in shared code, add @sentry/browser to suite-web and @sentry/electron to suite-desktop.
28b8d04 - initialize @sentry/electron and log domains filtered by request-filter (part of #4684).

@marekrjpolak marekrjpolak marked this pull request as ready for review February 4, 2022 11:44
@marekrjpolak marekrjpolak marked this pull request as draft February 4, 2022 12:29
@marekrjpolak marekrjpolak force-pushed the feat/4684-remove-filter-popup branch 2 times, most recently from 0cd1b5b to 28b8d04 Compare February 23, 2022 10:21
@marekrjpolak marekrjpolak changed the title feat(suite-desktop): remove request-filter popup Sentry in electron Feb 23, 2022
@marekrjpolak marekrjpolak marked this pull request as ready for review February 23, 2022 11:08
@marekrjpolak marekrjpolak requested a review from mroz22 as a code owner February 23, 2022 11:08
@matejkriz matejkriz force-pushed the feat/4684-remove-filter-popup branch from 28b8d04 to 90e95bd Compare February 24, 2022 14:55
@matejkriz
Copy link
Member

follow-up issue #4997

@matejkriz matejkriz force-pushed the feat/4684-remove-filter-popup branch from 90e95bd to 0053c07 Compare February 25, 2022 10:05
@matejkriz matejkriz merged commit 6645643 into develop Feb 25, 2022
@matejkriz matejkriz deleted the feat/4684-remove-filter-popup branch February 25, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejkriz matejkriz matejkriz approved these changes

@tomasklim tomasklim Awaiting requested review from tomasklim

@mroz22 mroz22 Awaiting requested review from mroz22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marekrjpolak @matejkriz