Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentry enhancements - adding context #4997

Closed
5 tasks done
matejkriz opened this issue Feb 24, 2022 · 2 comments · Fixed by #5502
Closed
5 tasks done

Sentry enhancements - adding context #4997

matejkriz opened this issue Feb 24, 2022 · 2 comments · Fixed by #5502
Assignees
@matejkriz
Labels
code Code improvements sentry Reports linked from Sentry.io or Sentry enhancements

Comments

@matejkriz
Copy link
Member

matejkriz commented Feb 24, 2022 •
edited
Loading

Add more context/tags to the Sentry issue:

  • transport type (as a tag)
    [wip] feat: add transport to sentry #5095
  • current route path including app, foregroundapp and fullscreen app (errors from desktop are missing the information about current location, for web there are full URLs)
  • tor status
  • FW and bootloader versions
  • device.mode?, device.type?

Stop reporting some useless errors:

'ERR_INTERNET_DISCONNECTED',
'ERR_NETWORK_IO_SUSPENDED',
'ERR_NETWORK_CHANGED',
'Error: HTTP Error',
'other call in progress',
'Action cancelled by user',
'ResizeObserver loop limit exceeded',
'device disconnected during action',
@matejkriz matejkriz added the code Code improvements label Feb 24, 2022
@matejkriz matejkriz mentioned this issue Feb 24, 2022
Merged
@hynek-jina hynek-jina added HIGH and removed MEDIUM labels Mar 29, 2022
@matejkriz matejkriz self-assigned this Apr 4, 2022
@hynek-jina hynek-jina moved this to 🏃‍♀️ In progress in Issues Suite Apr 4, 2022
@hynek-jina hynek-jina moved this from 🏃‍♀️ In progress to 🎯 To do in Issues Suite Apr 14, 2022
@matejkriz matejkriz changed the title Sentry in electron enhancements Sentry enhancements Apr 20, 2022
@matejkriz matejkriz added the sentry Reports linked from Sentry.io or Sentry enhancements label Apr 22, 2022
@matejkriz matejkriz moved this from 🎯 To do to 🏃‍♀️ In progress in Issues Suite May 24, 2022
@matejkriz matejkriz mentioned this issue May 26, 2022
Merged
2 tasks
@hynek-jina hynek-jina removed the HIGH label Jun 8, 2022
@matejkriz matejkriz moved this from 🏃‍♀️ In progress to 🎯 To do in Issues Suite Jun 23, 2022
@tomasklim
Copy link
Member

When tor tag is added to sentry, please check again #5793 that it happens on both tor and clear web

@matejkriz matejkriz moved this from 🎯 To do to 🏃‍♀️ In progress in Issues Suite Jul 19, 2022
@matejkriz matejkriz mentioned this issue Jul 19, 2022
Open
@matejkriz matejkriz linked a pull request Jul 29, 2022 that will close this issue
Feat/4997 sentry enhancement #5502
Merged
2 tasks
Repository owner moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Issues Suite Aug 2, 2022
@matejkriz matejkriz changed the title Sentry enhancements Sentry enhancements - adding context Aug 3, 2022
@matejkriz matejkriz moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Aug 3, 2022
@matejkriz
Copy link
Member Author

There is nothing to test from user perspective, regular sanity tests will cover it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejkriz matejkriz

Labels
code Code improvements sentry Reports linked from Sentry.io or Sentry enhancements
Projects
Issues Suite
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/4997 sentry enhancement trezor/trezor-suite
3 participants
@matejkriz @hynek-jina @tomasklim