Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethereum definitions send from host #6442

Closed
marnova opened this issue Oct 3, 2022 · 2 comments · Fixed by #7880
Closed

Ethereum definitions send from host #6442

marnova opened this issue Oct 3, 2022 · 2 comments · Fixed by #7880
Assignees
@karliatto @mroz22
Labels
code Code improvements connect Connect API related (ie. fee calculation)

Comments

@marnova
Copy link

marnova commented Oct 3, 2022

Firmware will be removing most of the Ethereum definitions for networks and tokens from the code and they will be send as a part of the messages from host to device.

Definitions will be awailable as a binary blobs at data.trezor.io. trezorctl and trezorlib will be prepared to download them and send them to device. Code for TT,trezorctl and trezorlib is ready to test (but minor changes may still come, code is still WIP) here trezor/trezor-firmware#2410.

Original issue for this change is here trezor/trezor-firmware#15.
@marnova marnova added the code Code improvements label Oct 3, 2022
@marnova marnova mentioned this issue Oct 3, 2022
Closed
@sime sime added the connect Connect API related (ie. fee calculation) label Oct 3, 2022
@sime sime moved this to 🎯 To do in Issues Suite Oct 3, 2022
@hynek-jina
Copy link
Contributor

Consider old Suite versions with new Firmware behaviour... @mroz22

@sime sime added this to the 23.3 Release milestone Jan 5, 2023
@sime sime mentioned this issue Jan 24, 2023
Closed
@hynek-jina hynek-jina removed this from the 23.3 Release milestone Feb 22, 2023
@Hannsek Hannsek moved this from 🎯 To do to 🏃‍♀️ In progress in Issues Suite Mar 17, 2023
@mroz22 mroz22 mentioned this issue Mar 22, 2023
Merged
3 tasks
@karliatto karliatto moved this from 🏃‍♀️ In progress to 🔎 Needs review in Issues Suite Mar 31, 2023
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Issues Suite Mar 31, 2023
@karliatto karliatto mentioned this issue Apr 3, 2023
Merged
@bosomt
Copy link
Contributor

bosomt commented Apr 18, 2023

QA OK

tested on web version EAP on staging with LPT token /tested before with stable tokens like PAX or USDT/

Image

Info:

  • Suite version: web 23.4.2 (5c5b3c8)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/112.0
  • OS: MacIntel
  • Screen: 2160x1350
  • Device: model T 2.6.0 Universal (revision 88e1f8c7a5c7615723664c64b0a25adc0c409dee)
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Apr 18, 2023
@bosomt bosomt mentioned this issue Apr 18, 2023
Merged
This was referenced Apr 20, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karliatto karliatto

@mroz22 mroz22

Labels
code Code improvements connect Connect API related (ie. fee calculation)
Projects
Issues Suite
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: ethereum definitions trezor/trezor-suite
6 participants
@sime @karliatto @hynek-jina @mroz22 @bosomt @marnova