Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic recognition of unverified ETH tokens #7444

Closed
mkolar242 opened this issue Jan 24, 2023 · 4 comments
Closed

Automatic recognition of unverified ETH tokens #7444

mkolar242 opened this issue Jan 24, 2023 · 4 comments
Assignees
Labels
EVM Issues related to networks based on Ethereum Virtual Machine

Comments

@mkolar242
Copy link

mkolar242 commented Jan 24, 2023

Design

list-of-tokens

unverified

hidden

Alert alert-tx-detail

Spec:
The prerequisite for this ticket is this #6595 and #6442

As a user, I expect Trezor Suite will be able to recognize unverified tokens in my account and add them to “Unverified” tokens list. Based on this action I can decide if I want to hide these tokens or not. When an “unverified” token lands in my account, I want to be notified about it.

Acceptance criteria

  • “Tokens” tab located in the Ethereum account detail has 4 tabs (list-of-tokens.png)
    • “All” - list of all available coins in the Ethereum account
    • “Tokens” - list of all coins excluding “Unverified” and “Hidden” tokens
      • “Tokens” tab indicates the number of tokens in the list
    • “Unverified” - list of all coins which are not whitelisted by Ethereum definitions database and which hasn’t been moved to whether “Tokens” or “Hidden” tokens list (unverified.png)
      • “Unverified” tab indicates the number of tokens in the list
      • Trezor Suite can look up the Ethereum definitions database with whitelisted tokens to identify any potential scam tokens
        • If the token is not found in the Ethereum definitions database then it has to be moved to “Unverified” tokens list
      • There is a description right below the list name: “These tokens have been flagged as unverified, which means their authenticity as legitimate projects cannot be confirmed. Please be cautious when interacting with these tokens.”
      • Each token has a warning icon next to its name - triangle with exclamation mark
        • If the token is moved to another list, the warning icon is removed
      • Each token has a button “Hide token”
        • Clicking the “Hide token” button moves the token to a “Hidden” list
      • Each token has a button “Approve token”
        • Clicking the “Approve token” button moves the token to a “Tokens” list
      • List of unverified tokens is collapsible
      • The list is collapsed by default
    • “Hidden” - list of all coins which where marked as hidden by the user (hidden.png)
      • “Hidden” tokens tab indicates the number of tokens in the list
      • List of hidden tokens is collapsible
      • The list is collapsed by default
  • Transaction with received “unverified” token needs to be displayed in the transaction history with a warning. Same logic as in the Address poisoning attack: Label zero value transactions in TX detail #7278 (comment)
    • There is a triangle icon with exclamation mark next to “Sent” or “Received” token (Alert.png)
      • Hovering over the warning icon displays a tool tip
      • Tool tip says: “Unverified token! This looks like a phishing attack (airdrop scam) and the token should not be used. Learn more.”
    • There is a red warning banner in the transaction detail modal window (Alert-tx-detail.png)
      • The banner is displayd right under the “Details” heading
      • The banner says: “This transaction is flagged as suspicious and could be a scam. Please proceed with caution. Learn more.”
@hynek-jina hynek-jina added the EVM Issues related to networks based on Ethereum Virtual Machine label Jan 24, 2023
@hynek-jina hynek-jina moved this to 🎯 To do in Issues Suite Jan 30, 2023
@mjollnir14
Copy link

mjollnir14 commented Mar 12, 2023

Or a simpler fix in the first time: sort tokens by Ascending USD value. This will put the "fake/scam tokens" at the end of the list.

@AdamSchinzel
Copy link
Contributor

I don't think there is any official database of spam tokens published by the Ethereum Foundation or any other company.

Some Web3 APIs such as Moralis has it inside their own API or Etherscan has ERC-20 token reputation (seems to not be public based on their docs).

So there must be some metrics on blockbook what makes the ERC-20 token a spam token I guess.

@marian001
Copy link

Or allow user to enable tokens he/she wants to work with. And include an option to automatically enable tokens with non-zero balances.

@MiroslavProchazka MiroslavProchazka moved this to 🎯 To do in Issues Suite Jan 16, 2024
@tomasklim tomasklim added this to the Suite Trends H1/2024 milestone Jan 23, 2024
@AdamSchinzel AdamSchinzel mentioned this issue Jan 24, 2024
@tomasklim
Copy link
Member

@Hannsek maybe close in favor of #12165?

@Hannsek Hannsek closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2024
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Issues Suite May 3, 2024
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Issues Suite May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EVM Issues related to networks based on Ethereum Virtual Machine
Projects
Archived in project
Development

No branches or pull requests

7 participants