Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hiding Ethereum tokens #6595

Closed
mkolar242 opened this issue Oct 19, 2022 · 26 comments
Closed

Hiding Ethereum tokens #6595

mkolar242 opened this issue Oct 19, 2022 · 26 comments
Assignees
@AdamSchinzel
Labels
EVM Issues related to networks based on Ethereum Virtual Machine feature Product related issue visible for end user
Milestone
Suite Trends H1/2024

Comments

@mkolar242
Copy link

mkolar242 commented Oct 19, 2022 •
edited by MiroslavProchazka
Loading

Design in Figma

Spec:
Please use current component from Empower.

As a user, I would like to have the ability to hide whether scam airdrop tokens or zero balance tokens.

Implementation for SOL, ETH, MATIC and ADA.
Leave the Trade button for now, display just the receive and send buttons.
Tokens state (recognized/unrecognized) should be reflected also in the Send select dropdown menu.

Save the info about what is hidden into labeling. All related transactions to hidden tokens should be blurred.

Settings

  • settings to be available per account
  • stored files to be encrypted
@hynek-jina hynek-jina added ERC20 altcoins not related to bitcoin labels Oct 19, 2022
@420-Bits
Copy link

Please we need this!! ASAP!!

@sime sime added this to the 23.3 Release milestone Jan 5, 2023
@quickplaymobile
Copy link

quickplaymobile commented Jan 19, 2023 •
edited
Loading

Proposal to also remove the transactions tx for hidden tokens and probably implementing a curated list for automatically blocking them.
https://www.bitdefender.com/blog/hotforsecurity/new-address-poisoning-crypto-scam-on-the-rise-metamask-warns/

@mkolar242 mkolar242 mentioned this issue Jan 24, 2023
Closed
@hynek-jina hynek-jina moved this to 🎯 To do in Suite Desktop Feb 2, 2023
@hynek-jina hynek-jina removed this from the 23.3 Release milestone Feb 22, 2023
@tomasklim
Copy link
Member

tomasklim commented Apr 5, 2023 •
edited
Loading

@mkolar242

  • token price is missing in the design
  • should it open etherscan or blockbook
  • stored files to be encrypted, I think we should discuss this. Not straightforward and maybe we want it for whole Suite @sime
  • how about ERC755 and ERC1155

@mkolar242
Copy link
Author

mkolar242 commented Apr 5, 2023 •
edited
Loading

@tomasklim

  • we show token amount + token value in fiat -> we have this in design
  • open blockbook
  • no plan to show ERC721 and ERC1155 in the tokens list
  • lets discuss the files encryption next week
  • I will update the spec as we also need to remove txs from the tx history

@tomasklim
Copy link
Member

tomasklim commented Apr 6, 2023 •
edited
Loading

we show token amount + token value in fiat

As a user, I would like to know token price if available. This force me to do "complex" math 😀 We show price of BTC, ETH,.. but we will miss token price, which is not even available in blockbook so I will have to go to coingecko/coinmarketcap

I will update the spec as we also need to remove txs from the tx history

Please discuss this with @sime

@tomasklim tomasklim mentioned this issue Apr 26, 2023
Closed
@tomasklim
Copy link
Member

tomasklim commented Apr 26, 2023 •
edited
Loading

related #3957 #3898

@tomasklim
Copy link
Member

Any plan with this Add token modal?

Image

@dbarobin
Copy link

dbarobin commented May 9, 2023

Please, I desperately need this feature. The fake USDT tokens are so annoying.

SCR-20230509-b2y

@sime
Copy link
Contributor

sime commented May 9, 2023

Any plan with this Add token modal?

Image

My understanding is we can drop it since blockbook was updated and its original use case is gone.

@HaydenOtto
Copy link

Do the devs even use their own wallet? Or do they simply not care about this because they are Bitcoin maxis and this issue only effects Ethereum plebs? This is the single greatest problem I have with Trezor walets and it has been ongoing for years now. Can't believe nothing has been done about it and from a developer perspective it shouldn't be hard to implement the ability to hide tokens from the UI.

@dbarobin
Copy link

Do the devs even use their own wallet? Or do they simply not care about this because they are Bitcoin maxis and this issue only effects Ethereum plebs? This is the single greatest problem I have with Trezor walets and it has been ongoing for years now. Can't believe nothing has been done about it and from a developer perspective it shouldn't be hard to implement the ability to hide tokens from the UI.

Totally agree. Don't ignore the feelings of users because of your own beliefs. It's not that Trezor doesn't support Ethereum.

@dbarobin
Copy link

OMG, I can't stand it anymore. I think it would be a good idea to launch the hidden token feature as soon as possible.

SCR-20230613-mqd

@Hannsek
Copy link
Contributor

Hannsek commented Jun 13, 2023

We are currently working on it. However, there are plenty of other features. Please be patient. 🙏🏻

@tomasklim
Copy link
Member

Screenshot 2023-07-20 at 10 40 06
Long token symbols does not fit screen
Screenshot 2023-07-20 at 10 40 28

@Hannsek Hannsek mentioned this issue Oct 16, 2023
Closed
@Hannsek
Copy link
Contributor

Hannsek commented Oct 23, 2023

notes:

  • automatically hide transactions (if any) with hidden tokens
  • sort tokens according to fiat value

@HaydenOtto
Copy link

@Hannsek are the above features you mentioned implemented? I can't see anything related to that and I am on the latest firmwares.

@Hannsek
Copy link
Contributor

Hannsek commented Nov 18, 2023

Not yet.

@dbarobin
Copy link

I can't even filter which is the correct USDT when transferring funds.

SCR-20231119-m6h

@nzjrs

This comment was marked as off-topic.

Sign in to view
@xTnK

This comment was marked as duplicate.

Sign in to view
@tomasklim
Copy link
Member

TODO: do not fetch fiat rates for tokens without definitions Screenshot 2024-01-02 at 5 02 55

@matejkriz matejkriz mentioned this issue Jan 3, 2024
Open
@nzjrs

This comment was marked as off-topic.

Sign in to view
@marian001

This comment was marked as off-topic.

Sign in to view
@quickplaymobile
Copy link

quickplaymobile commented Jan 11, 2024 •
edited
Loading

pic 2
pic 1
It becomes increasingly harder to protect ourselves. Please help us protect ourselves, please help us hide them.

@MiroslavProchazka MiroslavProchazka moved this to 🎯 To do in Suite Desktop Jan 11, 2024
@tomasklim tomasklim mentioned this issue Jan 20, 2024
Closed
@AdamSchinzel AdamSchinzel added EVM Issues related to networks based on Ethereum Virtual Machine and removed ERC20 labels Jan 23, 2024
@tomasklim tomasklim added this to the Suite Trends H1/2024 milestone Jan 23, 2024
@tomasklim tomasklim mentioned this issue Jan 23, 2024
Closed
@tomasklim tomasklim added feature Product related issue visible for end user and removed altcoins not related to bitcoin labels Jan 23, 2024
@AdamSchinzel AdamSchinzel mentioned this issue Jan 24, 2024
Closed
@tomasklim
Copy link
Member

Together with feature what is hidden,... we can store #3883

This was referenced Feb 5, 2024
Closed
Closed
@Hannsek Hannsek mentioned this issue Apr 26, 2024
Closed
@Hannsek
Copy link
Contributor

Hannsek commented Apr 26, 2024

Closing in favour of #12165

@Hannsek Hannsek closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2024
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Suite Desktop Apr 26, 2024
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdamSchinzel AdamSchinzel

Labels
EVM Issues related to networks based on Ethereum Virtual Machine feature Product related issue visible for end user
Projects
Suite Desktop
Archived in project
Milestone
Suite Trends H1/2024
Development

No branches or pull requests
14 participants
@nzjrs @sime @dbarobin @marian001 @quickplaymobile @hynek-jina @HaydenOtto @tomasklim @mkolar242 @Hannsek @420-Bits @AdamSchinzel @xTnK and others