Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve transaction detail amounts #7109

Open
7 tasks
hynek-jina opened this issue Dec 2, 2022 · 0 comments
Open
7 tasks

Improve transaction detail amounts #7109

hynek-jina opened this issue Dec 2, 2022 · 0 comments
Labels
code Code improvements coinjoin Related to coinjoin feature transactions Transaction history page

Comments

@hynek-jina
Copy link
Contributor

hynek-jina commented Dec 2, 2022

Changes applies generally to all kind of transactions (Not only CoinJoin)

Display: Total, Amount, Fee, and in CoinJoin transaction Service too.
Detail

  • Rename Amount tab to Amounts
  • Remove Total inputs and Total outputs from Amount tab of transaction detail
    this metric is quite confusing for users and doesn't bring much value. Numbers are still accessible in mempool.
  • Add Total with higher visibility then other metrics (my inputs - my outputs) → total balance change The same number is visible in transaction history.
  • Change Amount meaning:
    • Send transaction → Receivers outputs (displayed witch negative sign)
    • Receive transaction = Received amount (no change)
    • Send to myself transaction = 0
    • CoinJoin transaction = 0
  • Change meaning of Fee from fee of whole transaction to part of fee paid by user
    • It results in negative sign in send transaction. 0 in receive transaction. Users part of fee in CoinJoin transaction.

CoinJoin specific part

  • Add Service fee for CoinJoin transactions displaying part of fee paid to coordinator
  • Consider distinguishing Dust fee - too small funds dropped in the transaction

Related issue: #6973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code improvements coinjoin Related to coinjoin feature transactions Transaction history page
Projects
Status: 🎯 To do
Development

No branches or pull requests

2 participants