-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ethereum improvements and internal transactions #7805
Conversation
c9f993d
to
b12f5f3
Compare
54255ab
to
6f7b569
Compare
86e88b1
to
8297a73
Compare
e0134f3
to
cfc65c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A migration is needed to make sure that internalTransfers
is []
. If a devce had been remembered, the app would otherwise crash.
I haven't tested some things like exports or NFTs, will have another review round tomorrow! 🙌
packages/suite/src/components/wallet/TransactionItem/components/Target.tsx
Outdated
Show resolved
Hide resolved
packages/suite/src/components/suite/modals/TransactionDetail/components/IODetails.tsx
Outdated
Show resolved
Hide resolved
packages/suite/src/components/suite/modals/TransactionDetail/components/IODetails.tsx
Show resolved
Hide resolved
packages/suite/src/components/wallet/TransactionItem/components/TransactionHeader.tsx
Show resolved
Hide resolved
e2b760e
to
50e97ed
Compare
packages/suite/src/components/suite/modals/TransactionDetail/components/IODetails.tsx
Outdated
Show resolved
Hide resolved
packages/suite/src/components/suite/modals/TransactionDetail/components/IODetails.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅✅✅
Description
name
Show Fiat
button Improve transaction detail amounts #7109contract
to work with blockbookcontract
Related Issue
closes #7368
fixes https://satoshilabs.slack.com/archives/C03SRP8PSS2/p1676543488631379
#7109
Screenshots:
Inputs/Outputs:
Amount:
Transaction list
Tokens section:
- BTC inputs outputs
Contract transaction
Follow-up
address
tocontract
on all placestype
collides with tokentype
(ERC20,...)contract
tx type icon Ethereum contract creation/destruction tx type #8017self
txs - signs + amount Transaction detail - Signs when sending to myself, sending zero value #8016