Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detecting fraud tx on many places within a codebase #8007

Closed
tomasklim opened this issue Apr 5, 2023 · 0 comments · Fixed by #10034
Closed

Detecting fraud tx on many places within a codebase #8007

tomasklim opened this issue Apr 5, 2023 · 0 comments · Fixed by #10034
Assignees
@tomasklim
Labels
code Code improvements

Comments

@tomasklim
Copy link
Member

Right now we check isZeroValuePhishing on many places within a code.

I suggest to detect it on one place and store it together with tx object.

If there is a plan to detect it in blockbook, this can be taken as preparation.
@tomasklim tomasklim added the code Code improvements label Apr 5, 2023
@tomasklim tomasklim mentioned this issue Apr 5, 2023
Merged
@sime sime mentioned this issue Apr 20, 2023
Closed
@tomasklim tomasklim mentioned this issue Jan 30, 2024
Merged
@tomasklim tomasklim self-assigned this Feb 5, 2024
@tomasklim tomasklim moved this to 🔎 Needs review in Issues Suite Feb 5, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Issues Suite Feb 6, 2024
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomasklim tomasklim

Labels
code Code improvements
Projects
Issues Suite
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

EVM poisoning vol. 2 trezor/trezor-suite
1 participant
@tomasklim