EVM poisoning vol. 2 #10034
Merged
EVM poisoning vol. 2 #10034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasklim
force-pushed
the
feat/tag-scammy-txs
branch
6 times, most recently
from
44f229f to
a6c8a75
Compare
AdamSchinzel
reviewed
Feb 1, 2024
suite-common/wallet-core/src/tokenDefinitions/tokenDefinitionsActions.ts
Outdated
Show resolved
Hide resolved
...e/modals/ReduxModal/UserContextModal/TxDetailModal/AdvancedTxDetails/IODetails/IODetails.tsx
Show resolved
Hide resolved
tomasklim
force-pushed
the
feat/tag-scammy-txs
branch
2 times, most recently
from
6ae7d78 to
1d763fb
Compare
tomasklim
requested review from
alex-jerechinsky and
matejkriz
as code owners
tomasklim
force-pushed
the
feat/tag-scammy-txs
branch
from
1d763fb to
36a596d
Compare
tomasklim
added
the
release
Nodonisko
requested changes
Feb 5, 2024
|
|
||
| isTokenKnown = fetchedTokenDefinition.ok; | ||
|
|
||
| dispatch( |
There was a problem hiding this comment.
Don't create extra actions for success/fail thunks. RTK has built-in support for these https://redux-toolkit.js.org/api/createAsyncThunk#examples and https://redux-toolkit.js.org/api/createAsyncThunk#handling-thunk-errors
Nodonisko
reviewed
Feb 5, 2024
...uite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/TxDetailModal.tsx
Outdated
Show resolved
Hide resolved
PeKne
reviewed
Feb 6, 2024
suite-common/wallet-core/src/token-definitions/tokenDefinitionsReducer.ts
Outdated
Show resolved
Hide resolved
suite-common/wallet-core/src/token-definitions/tokenDefinitionsReducer.ts
Outdated
Show resolved
Hide resolved
packages/suite/src/views/wallet/tokens/components/TokenList.tsx
Outdated
Show resolved
Hide resolved
suite-common/wallet-core/src/token-definitions/tokenDefinitionsThunk.ts
Outdated
Show resolved
Hide resolved
tomasklim
force-pushed
the
feat/tag-scammy-txs
branch
from
36a596d to
2c3b912
Compare
tomasklim
force-pushed
the
feat/tag-scammy-txs
branch
2 times, most recently
from
0af5c01 to
32c6199
Compare
Nodonisko
reviewed
Feb 6, 2024
suite-common/wallet-core/src/token-definitions/tokenDefinitionsThunks.ts
Show resolved
Hide resolved
Nodonisko
approved these changes
Feb 6, 2024
tomasklim
force-pushed
the
feat/tag-scammy-txs
branch
from
4a46be2 to
ff9e384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updateSelectedAccountRelated Issue
Resolves #8119
Resolves #10783
Resolves #8007 I slightly refactored the logic, it cannot be part of tx as we need to fetch token definitions first
Resolves #11037
Resolves #11040
Screenshots: