Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFTs section #8004

Closed
Tracked by #12165
tomasklim opened this issue Apr 5, 2023 · 6 comments · Fixed by #15467
Closed
Tracked by #12165

NFTs section #8004

tomasklim opened this issue Apr 5, 2023 · 6 comments · Fixed by #15467
Assignees
Labels
EVM Issues related to networks based on Ethereum Virtual Machine

Comments

@tomasklim
Copy link
Member

tomasklim commented Apr 5, 2023

Screenshot 2024-06-11 at 17 15 36

Describe the bug

  • ERC721, ERC1155 are filtered out so they do not arrive to Suite UI (not sure where)

Expected behavior
I will see NFTs in Suite. I want to be able to filter by ERC721 and ERC1155. Rabby does not distinguish
Screenshot 2024-05-02 at 12 24 06

What we get from BlockBook:

ERC1155

{
  "type": "ERC1155",
  "name": "Airdrop at linkredeem.io",
  "contract": "0x43721eF8de94FD33E23eE267546d67CeFdB1968C",
  "transfers": 1,
  "symbol": "NFT",
  "decimals": 18,
  "multiTokenValues": [
    {
      "id": "1",
      "value": "1"
    }
  ]
}

Link to BlockBook: https://matic1.trezor.io/nft/0x43721eF8de94FD33E23eE267546d67CeFdB1968C/1

What is interesting for us?
type (ERC-1155)
name (Collection)
symbol
contract address
ID (id of NFT, number)
amount (how many of specific NFT with specific ID I have)
number of transfers

ERC721:

{
  "type": "ERC721",
  "name": "AstronomiaMeta",
  "contract": "0x23A864B6bB94518B0FA41d17f8f52ea38A826457",
  "transfers": 1,
  "symbol": "AstronomiaMeta",
  "decimals": 18,
  "ids": [
    "95729"
  ]
}

Link to BlockBook: https://eth1.trezor.io/nft/0x8506540784ec25A19aB750741A4AB1b6D8790e2c/1

What is interesting for us?
type (ERC-720)
name (Collection)
symbol
contract address
ID (id of NFT, number, there is always just 1 unique)
number of transfers

Icon for recognised NFTs can be fetched from coingecko. It is not circle but square
Screenshot 2024-05-02 at 12 22 27

User can have more NFTs from same collection. Do we want to put collections together or just have it as a new token?
type (ERC-720)
name (Collection)
symbol
contract address
number of transfers

  • icon

is for collection.

ID (id of NFT, number)
amount (how many of specific NFT with specific ID I have)

for item

@tomasklim tomasklim added the bug Something isn't working as expected label Apr 5, 2023
@tomasklim tomasklim added the EVM Issues related to networks based on Ethereum Virtual Machine label Apr 7, 2023
@tomasklim
Copy link
Member Author

#8036 interesting links included

@tomasklim tomasklim added this to the Suite Trends H1/2024 milestone Jan 23, 2024
@AdamSchinzel AdamSchinzel mentioned this issue Jan 24, 2024
@tomasklim tomasklim changed the title ERC721, ERC1155 visible only in transfers, not in Tokens tab NFTs section May 2, 2024
@tomasklim tomasklim mentioned this issue May 2, 2024
@tomasklim tomasklim removed the bug Something isn't working as expected label Jun 11, 2024
@tomasklim
Copy link
Member Author

tomasklim commented Jun 14, 2024

@AdamSchinzel let's add it in experimental features for first versions

@tomasklim tomasklim moved this to 🎯 To do in Suite Desktop Jun 29, 2024
@tomasklim tomasklim removed this from the Suite Trends H1/2024 milestone Aug 10, 2024
@enjojoy enjojoy self-assigned this Oct 10, 2024
@enjojoy
Copy link
Contributor

enjojoy commented Oct 30, 2024

NFT -> NFT and HIDDEN -> Two tables for 2 types of tokens

No picture, no receive, no send, copy contract address, show transaction history, link to blockbook where pictures are sown.

@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Suite Desktop Dec 20, 2024
@tomasklim
Copy link
Member Author

@trezor/qa please wait with testing, @enjojoy will prepare manual for you and everything needed

@bosomt
Copy link
Contributor

bosomt commented Jan 3, 2025

Manual here : #15467 (comment)

@bosomt
Copy link
Contributor

bosomt commented Jan 7, 2025

QA OK

#15467 (comment)

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EVM Issues related to networks based on Ethereum Virtual Machine
Projects
Status: ✅ Approved
Development

Successfully merging a pull request may close this issue.

3 participants