Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tx with ERC-1155 shows only first NFT available, without # of units #8036

Closed
Tracked by #12165
tomasklim opened this issue Apr 7, 2023 · 4 comments · Fixed by #15457
Closed
Tracked by #12165

Tx with ERC-1155 shows only first NFT available, without # of units #8036

tomasklim opened this issue Apr 7, 2023 · 4 comments · Fixed by #15457
Assignees
@enjojoy
Labels
bug Something isn't working as expected EVM Issues related to networks based on Ethereum Virtual Machine

Comments

@tomasklim
Copy link
Member

tomasklim commented Apr 7, 2023 •
edited
Loading

Describe the bug

Right now, we show only first ERC-1155 within a transaction without units.
https://github.com/trezor/trezor-suite/blob/develop/suite-common/wallet-utils/src/transactionUtils.ts#L413
https://github.com/trezor/trezor-suite/blob/develop/packages/suite/src/components/suite/FormattedNftAmount.tsx#L48

Info:

  • Suite Version: 23.4.0

How to reproduce
https://ethereum.org/en/developers/docs/standards/tokens/erc-1155/

Example tx:
https://etherscan.io/tx/0xa3074c72e058a29f077f5c478e86dd600623c562939e5ce0a3a3cb65b7a4a706
https://eth1.trezor.io/api/v2/tx/0xa3074c72e058a29f077f5c478e86dd600623c562939e5ce0a3a3cb65b7a4a706

Example address with NFTs:
https://eth1.trezor.io/address/0x958B69371e5750Ca8e6436f122322d68b395f781
https://etherscan.io/token/0x05baf9f1961e1ed1dac222a1f97c479441b31b34?a=81#inventory

Expected behavior

  • shows all NFTs of tx
  • shows value of NFT

Screenshot 2023-04-07 at 21 51 54
@tomasklim tomasklim added bug Something isn't working as expected EVM Issues related to networks based on Ethereum Virtual Machine labels Apr 7, 2023
@tomasklim tomasklim mentioned this issue Apr 7, 2023
Closed
@sime
Copy link
Contributor

sime commented May 15, 2023

@tomasklim Seems like a blockbook problem first?

@tomasklim
Copy link
Member Author

I think the data we are getting are correct

@tomasklim tomasklim added this to the Suite Trends milestone Jan 23, 2024
@AdamSchinzel AdamSchinzel mentioned this issue Jan 24, 2024
Closed
@tomasklim tomasklim mentioned this issue Jul 2, 2024
Closed
@tomasklim tomasklim removed this from the Suite Trends H1/2024 milestone Aug 10, 2024
@enjojoy enjojoy self-assigned this Sep 2, 2024
@enjojoy
Copy link
Contributor

enjojoy commented Nov 19, 2024

The data are correct and we get all the multitoken values, it just has to be displayed on the frontend

image

@enjojoy enjojoy mentioned this issue Nov 19, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Suite Desktop Dec 3, 2024
@bosomt
Copy link
Contributor

bosomt commented Dec 3, 2024 •
edited
Loading

QA OK

Image

image

Info:

  • Suite version: web 24.12.0 (8e06da9)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.6 regular (revision 688bddc887b8bb660640cc6e40a99036f2e87f1f)
  • Transport: WebUsbTransport

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enjojoy enjojoy

Labels
bug Something isn't working as expected EVM Issues related to networks based on Ethereum Virtual Machine
Projects
Suite Desktop
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display all tokens in a multitoken tx trezor/trezor-suite
4 participants
@sime @bosomt @tomasklim @enjojoy