Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite): copy contract address warning #12934

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

AdamSchinzel
Copy link
Contributor

@AdamSchinzel AdamSchinzel commented Jun 18, 2024

Description

Warn users before copying contract address and educate them that It's not their receive address. Copy is from Chris.

Related Issue

Resolve #12842

Screenshots:

Screenshot 2024-06-18 at 9 39 32 AM

@AdamSchinzel AdamSchinzel requested a review from tomasklim June 18, 2024 06:51
@AdamSchinzel AdamSchinzel force-pushed the feat/copy-contract-address-warning branch 3 times, most recently from e3c6a73 to 6d66639 Compare June 18, 2024 07:41
Copy link
Member

@tomasklim tomasklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side would be nice to polish modal with @jvaclavik

I think that we should also improve wording in the modal but this is different story and we can do it in crowdin

Copy link
Contributor

@jvaclavik jvaclavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving 👍

just FYI: color of the icon should be yellow and we are going to refactor it in the future, because it needs deeper refactoring.

@AdamSchinzel AdamSchinzel force-pushed the feat/copy-contract-address-warning branch from 86194c9 to c2634aa Compare June 20, 2024 13:43
@AdamSchinzel AdamSchinzel enabled auto-merge (squash) June 20, 2024 13:44
@AdamSchinzel AdamSchinzel merged commit e003e50 into develop Jun 20, 2024
25 checks passed
@AdamSchinzel AdamSchinzel deleted the feat/copy-contract-address-warning branch June 20, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EVM Tokens / Fix copy icon alignment + copy warning
3 participants