fix(wallet-utils): allow tokens without symbol and valid balance #13323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasklim
force-pushed
the
fix/evm-tokens
branch
from
c4a0d0a to
c58c7fb
Compare
jvaclavik
approved these changes
Jul 15, 2024
| balance: formatAmount(t.balance!, t.decimals), | ||
| })); | ||
| name: t.name || symbol, | ||
| symbol: symbol.toLowerCase(), |
There was a problem hiding this comment.
nitpick:
You have this in the description:
ignore nonsense toLowerCase, there is another issue for that. Symbols can be mixed case
So why do you use toLowerCase here or am I missing something?
There was a problem hiding this comment.
I expressed myself poorly.
The lowercase does not make sense but I am keeping it there just to be sure that it does not break anything, but it will be removed soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
toLowerCase, there is another issue for that. Symbols can be mixed caseRelated Issue
Resolve #13322
Screenshots: