Update react hook form

[szymonlesisz]

Description

Someone finally has to do it :)

Kicking of react-hook-form update and looking for help

Breaking changes:

https://github.com/react-hook-form/react-hook-form/blob/master/CHANGELOG.md

Related to:
resolves #6596

i guess first we should update react-hook-form, test if working correctly and then update react-testing-library

[Nodonisko]

I will update suite-native part once you are done with desktop but should be quick, we have react-hook-form abstracted so we do not access API directly

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

[socket-security]

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@hookform/resolvers	1.3.8...3.1.0	None	+3/-3	3.04 MB	bluebill1049
react-hook-form	6.15.7...7.44.3	network	+0/-0	850 kB	bluebill1049

[komret]

Mostly done. I am investigating why some tests are failing, any insight appreciated - @dahaca, @szymonlesisz...

@trezor/invity-suite This upgrade involves a lot of changes to the coinmarket section of Suite, can you please also take a look at the PR?

@Nodonisko Minor changes to the suite-native package were also necessary due to changes in RHF's TS definitions.

[tomasklim]

According to migration docs and what I know about forms, it looks good imho. There are some problems with invity forms ⬇️

No idea regarding the useRbfForm test

[tomasklim]

The e2e coinmarket buy form is failing correctly.

I am not able to choose address

Buy BTC for 5k kč, choose Banxa, bank transfer. Try to select btc address.

Screen.Recording.2023-06-23.at.11.32.25.mov

[tomasklim]

Sell form with small amount worked weird before. Now it misses error

Before:

Screen.Recording.2023-06-23.at.11.36.18.mov

I have to interact with form again to see the error

Now:

Screen.Recording.2023-06-23.at.11.37.18.mov

Interaction does not help

In Exchange tab it worked before correctly (immediatelly), now it does not show the error

[tomasklim]

If I fill 0 i get an error in console. In production, I get error in form

[szymonlesisz]

i've checked failing tests for useSendForm and useRbfForm hooks. following changes has to be made to make it work:

1. useAsyncDebounce timeout is never cleared once triggered. therefore compose process is called even after the component is unmounted (test is finished)
   Clearing the timeout on unmount should help:

useEffect(
        () => () => {
            if (timeout.current) clearTimeout(timeout.current);
        },
        [],
 );

2. CustomFee component returns Translation in validate function. i should work when it will return string.

3. useCompose hook triggers compose process multiple times by changing the value of feeLimit to undefined
   Set fallback it to empty string in case when feeLimit in not present in composed tx (all btc like coins, only eth is working with feeLimit field)

setValue('feeLimit', feeLimit || '');

[komret]

As for the failing e2e test, it shouldn't matter. The field changed its name from outputs[0].address to outputs.0.address. The migration test checks the name on https://suite.corp.sldev.cz/suite-web/release/22.7/web/accounts/send where it hasn't been updated yet.

@ondracja FYI

[komret]

@LukasRada Can I merge the PR?

[LukasRada]

@komret Yes.

ok

[matejkriz]

/rebase

[github-actions]

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/5584662250