Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle symlinks #18

Closed
wants to merge 2 commits into from
Closed

Conversation

chrisblossom
Copy link
Contributor

@chrisblossom chrisblossom commented Mar 29, 2018

I've seen this issue come up on create-react-app (#648 and paths.js#L18).

Not sure if wanted (seems maybe a bit over thinking/engineering), also not sure how to write tests.

@coveralls
Copy link

coveralls commented Mar 29, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling af87ced on chrisblossom:handle-symlinks into 8d18c11 on tribou:master.

@tribou
Copy link
Owner

tribou commented Mar 30, 2018

Interesting catch on a potential issue. I could see symlinks being used in a CI environment, but we might just have to test locally on this one. Setup/teardown of creating/removing symlinks might get a bit dicey...

@chrisblossom
Copy link
Contributor Author

chrisblossom commented Apr 3, 2018

I started adding tests to this and found it is getting complicated very quickly. I think if this is something to be supported we may need to rethink how we are matching paths.

Here is where it starts getting complicated.

I'm going to close this for now until someone actually runs into this issue. I won't delete my WIP branch up for future reference.

@tribou
Copy link
Owner

tribou commented Apr 4, 2018

Oh wow, no problem at all. Regardless, thanks for all of the other PRs to help make this package more robust!

@chrisblossom
Copy link
Contributor Author

I just ran into this issue so I might try and solve it again. If you have any ideas a good please let me know.

@tribou
Copy link
Owner

tribou commented Apr 23, 2018

Yikes... Is there a gist or small repo you could create to reproduce the issue? If I had some more context to better understand (like an example), I'd be glad to help solve.

@chrisblossom
Copy link
Contributor Author

Do you use a mac for development?

@tribou
Copy link
Owner

tribou commented Apr 24, 2018

Yes, I do nowadays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants