-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle symlinks #18
Handle symlinks #18
Conversation
937b76f
to
7ae7ea0
Compare
Interesting catch on a potential issue. I could see symlinks being used in a CI environment, but we might just have to test locally on this one. Setup/teardown of creating/removing symlinks might get a bit dicey... |
7ae7ea0
to
e7b3fc6
Compare
e7b3fc6
to
af87ced
Compare
ea493fb
to
4b4e866
Compare
I started adding tests to this and found it is getting complicated very quickly. I think if this is something to be supported we may need to rethink how we are matching paths. Here is where it starts getting complicated. I'm going to close this for now until someone actually runs into this issue. I won't delete my WIP branch up for future reference. |
Oh wow, no problem at all. Regardless, thanks for all of the other PRs to help make this package more robust! |
I just ran into this issue so I might try and solve it again. If you have any ideas a good please let me know. |
Yikes... Is there a gist or small repo you could create to reproduce the issue? If I had some more context to better understand (like an example), I'd be glad to help solve. |
Do you use a mac for development? |
Yes, I do nowadays |
I've seen this issue come up on create-react-app (#648 and paths.js#L18).
Not sure if wanted (seems maybe a bit over thinking/engineering), also not sure how to write tests.