Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined method `include_ember_script_tags' #147

Closed
jesenko opened this issue Apr 9, 2015 · 4 comments
Closed

undefined method `include_ember_script_tags' #147

jesenko opened this issue Apr 9, 2015 · 4 comments

Comments

@jesenko
Copy link
Contributor

jesenko commented Apr 9, 2015

After upgrading to latest version of ember-cli-rails (0.3.1), ember-cli helpers are not available in views. I had to manually add helper EmberCLI::EmberRailsHelper to controller to include them. Probably related to 96f4d91.

Either documentation should be updated to manual inclusion of helpers or helpers should be automatically included.

Rails version: 4.1

@rwz
Copy link
Collaborator

rwz commented Apr 9, 2015

That's weird because it works for me. The engine exposes all its helpers by default.

@rwz
Copy link
Collaborator

rwz commented Apr 9, 2015

Could you provide a test app exposing the issue?

@jesenko
Copy link
Contributor Author

jesenko commented Apr 9, 2015

I traced it back to this entry in Rails config:

config.action_controller.include_all_helpers = false

Apparently engine does not expose its helpers if this is set...

@jesenko jesenko closed this as completed Apr 9, 2015
@jesenko jesenko reopened this Apr 9, 2015
@jesenko
Copy link
Contributor Author

jesenko commented Apr 9, 2015

I have created related PR #148

@jesenko jesenko closed this as completed Apr 9, 2015
@jesenko jesenko reopened this Apr 9, 2015
@rwz rwz closed this as completed in 355371e Apr 14, 2015
rwz added a commit that referenced this issue Apr 14, 2015
explicitly register helper, fixes #147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants