Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ember Tests from Rails Engine #264

Merged
merged 1 commit into from
Nov 13, 2015
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
master
------

* Remove support for viewing Ember tests through Rails. Instead, use `ember
test` or `ember test --serve` from within the Ember directory.
* Remove `build_timeout` configuration [#259]
* Disable JS minification when generating Heroku setup [#238]
* `BuildError#message` includes first line of backtrace. [#256]
20 changes: 0 additions & 20 deletions README.md
Original file line number Diff line number Diff line change
@@ -230,26 +230,6 @@ export default DS.RESTAdapter.extend({
});
```

## Ember Test Suite

To run an Ember app's tests in a browser, mount the `EmberCli::Engine`:

```ruby
# config/routes.rb

Rails.application.routes.draw do
mount EmberCli::Engine => "ember-tests" if Rails.env.development?

root "application#index"
end
```

Ember tests are served based on the route you mount the Engine on (in this
example, `/ember-tests`) and the name of the Ember app.

For example, to view tests of the `frontend` app, visit
`http://localhost:3000/ember-tests/frontend`.

### Integrating with Rake

EmberCLI Rails exposes the `ember:test` Rake task to execute Ember's test suite.
31 changes: 0 additions & 31 deletions app/controllers/ember_tests_controller.rb

This file was deleted.

3 changes: 0 additions & 3 deletions config/routes.rb

This file was deleted.

4 changes: 0 additions & 4 deletions lib/ember-cli/path_set.rb
Original file line number Diff line number Diff line change
@@ -53,10 +53,6 @@ def initialize(app:, rails_root:, ember_cli_root:, environment:, configuration:)
root.join("Gemfile")
end

define_path :tests do
dist.join("tests")
end

define_path :node_modules do
root.join("node_modules")
end
8 changes: 0 additions & 8 deletions spec/lib/ember-cli/path_set_spec.rb
Original file line number Diff line number Diff line change
@@ -80,14 +80,6 @@
end
end

describe "#tests" do
it "is a child of #dist" do
path_set = build_path_set

expect(path_set.tests).to eq path_set.dist.join("tests")
end
end

describe "#node_modules" do
it "is a child of #root" do
path_set = build_path_set