Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Ensure cleanup method can destroy temporary folders. #330

Closed
wants to merge 1 commit into from
Closed

[BUGFIX] Ensure cleanup method can destroy temporary folders. #330

wants to merge 1 commit into from

Conversation

patcoll
Copy link

@patcoll patcoll commented Dec 7, 2015

Fixes #329.

houndci-bot
houndci-bot reviewed Dec 7, 2015
View reviewed changes
lib/ember-cli-rails.rb
@@ -1,3 +1,4 @@
require 'fileutils'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@seanpdoyle
Copy link
Contributor

Thanks for submitting this fix!

It's a shame there isn't any way to configure Pathname#rmtree to do this.

Merged in 9960e58

@seanpdoyle seanpdoyle closed this Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patcoll @seanpdoyle @houndci-bot