Treat non {test,development} envs as production
#366
Merged
+84
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
current-environment
branch
from
d0c25de
to
219f546
Compare
seanpdoyle
force-pushed
the
current-environment
branch
3 times, most recently
from
1fd6bd5
to
04444b9
Compare
Closes [#361]. When the Rails environment is neither `test` nor `development` ([two environments handled by EmberCLI out-of-the-box][ember-cli-env]), treat it as `production`, unless an `EMBER_ENV` is specified. [#361]: #361 [ember-cli-env]: http://ember-cli.com/user-guide/#Environments
seanpdoyle
force-pushed
the
current-environment
branch
from
04444b9
to
94b7dd6
Compare
| ## `EMBER_ENV` | ||
|
|
||
| If set on the environment, the value of `EMBER_ENV` will be passed to the | ||
| `ember` process as the value of the `--environment` flag. |
There was a problem hiding this comment.
I'm a bit confused on this. Doesn't this code always force the environment passed to --environment to be either development or production?
There was a problem hiding this comment.
@seanpdoyle Did you see the above comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #361.
When the Rails environment is neither
testnordevelopment(twoenvironments handled by EmberCLI out-of-the-box), treat
it as
production, unless anEMBER_ENVis specified.