Remove bin/heroku_install
#544
Conversation
spec/lib/ember_cli_spec.rb
Outdated
| end | ||
|
|
||
| def stub_apps(applications) | ||
| allow(EmberCli).to receive(:apps).and_return(applications) |
There was a problem hiding this comment.
Use 2 (not 4) spaces for indentation.
spec/lib/ember_cli_spec.rb
Outdated
| it "delegates to the collection of applications" do | ||
| stub_apps( | ||
| app_with_foo: { foo: true }, | ||
| app_without_foo: { foo: false}, |
| if bower_enabled | ||
| cacheable_directories = [OUTPUT_DIRECTORY.join("bower_components")] | ||
| else | ||
| cacheable_directories =[] |
There was a problem hiding this comment.
Useless assignment to variable - cacheable_directories.
Surrounding space missing for operator =.
|
|
||
| def cacheable_directories(bower_enabled) | ||
| if bower_enabled | ||
| cacheable_directories = [OUTPUT_DIRECTORY.join("bower_components")] |
There was a problem hiding this comment.
Useless assignment to variable - cacheable_directories.
|
|
||
| allow_any_instance_of(EmberCli::App). | ||
| to receive(:cacheable_directories).and_return( | ||
| cacheable_directories(bower_enabled) |
There was a problem hiding this comment.
Put a comma after the last parameter of a multiline method call.
lib/ember_cli.rb
Outdated
| @@ -39,6 +39,10 @@ def skip? | |||
| ENV["SKIP_EMBER"].present? | |||
| end | |||
|
|
|||
| def any?(*arguments, &block) | |||
There was a problem hiding this comment.
Method EmberCli#any? is defined at both lib/ember_cli.rb:34 and lib/ember_cli.rb:42.
seanpdoyle
force-pushed
the
install-with-rake
branch
5 times, most recently
from
bd218c7
to
ef136b4
Compare
seanpdoyle
force-pushed
the
install-with-rake
branch
from
8e6d2fe
to
64b75af
Compare
For deployments to Heroku, depend on `rake ember:{build,install}` being
executed as part of `rake assets:precompile`.
The removal of `bin/heroku_install` as part of a `postinstall` script in
the root-level `package.json` simplifies support as well.
This commit modifies the setup to incorporate checks for the presence of
`bower.json` to determine whether or not to cache the corresponding
`bower_components` directories, as well as the up-front installation of
the `bower` CLI tool.
seanpdoyle
force-pushed
the
install-with-rake
branch
from
64b75af
to
989e610
Compare
|
Getting rid of heroku_install seems like a good change because it's easy to forget to update. When the NPM buildpack runs first and caches there's nothing installed yet so nothing to cache, and when the Ruby buildpack (Rails 4.2) runs it only looks for gems and doesn't seem to have customisable cache paths. I guess it could be addressed by adding custom cache paths to the ruby buildpack, or by adding generic buildpacks that can capture and restore custom cache paths at the start and end of the buildpack stack. |
For deployments to Heroku, depend on
rake ember:{build,install}beingexecuted as part of
rake assets:precompile.The removal of
bin/heroku_installas part of apostinstallscript inthe root-level
package.jsonsimplifies support as well.This commit modifies the setup to incorporate checks for the presence of
bower.jsonto determine whether or not to cache the correspondingbower_componentsdirectories, as well as the up-front installation ofthe
bowerCLI tool.