Split Compile from Language Feature #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
explore the effort of reading a gradle plugin property with the gradle tooling api.
Expose two environment variables to configure the frege compiler: - FREGE_LSP_SOURCE_DIR - FREGE_LSP_EXTRA_CLASSPATH
compileExecutor modules
code changes should drive the compilation. Therefore, compile the code in the didSave, didChange events and update the global. The language features the just get the information from the global. This does currently not work because I wrongly used an IO Global as state. Instead it should be a Global only that we can get with performUnsafe. Otherwise we stay in IO and due to the laziness no work, that means no compilation is done. Search for the marked TODO in the code to see where to make the changes. Rebase on main first!
Resolves all the todos introduced by the previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27.
Code changes should drive the compilation. Therefore, compilation is triggered in the didSave, didChange events and update the global. The language features then just get the information from the global. Besides, this makes the language features pure (no more IO dependency from compile).