Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sudo-rs does not set the terminal foreground process group #360

Closed
pvdrz opened this issue May 25, 2023 · 0 comments · Fixed by #520
Closed

sudo-rs does not set the terminal foreground process group #360

pvdrz opened this issue May 25, 2023 · 0 comments · Fixed by #520
Assignees
Labels
bug Something isn't working non-compliant used to track failing compliance tests
Milestone

Comments

@pvdrz
Copy link
Collaborator

pvdrz commented May 25, 2023

Describe the bug
sudo-rs does not set the command as the foreground process for the pty follower.

To Reproduce
Steps to reproduce the behavior:

  1. Compile sudo-rs and use any sudoers file that lets you execute commands as any user.
  2. Run any long-running command with sudo, like yes
  3. Check ps aux | grep yes and notice that the monitor is the foreground process instead of the actual command (i.e. the monitor has a + sign in the STAT column and the command does not).

Expected behavior
The command should be the foreground process for the pty.

Environment (please complete the following information):

  • Linux distribution: Arch Linux (btw) with kernel 6.3.3
  • sudo-rs commit hash: e13cab0

Additional context
This might be the reason why ^Z is ignored by sudo-rs at the moment. Still need to investigate. So it might be related to #245 and #325

cc @squell

@pvdrz pvdrz added bug Something isn't working non-compliant used to track failing compliance tests labels May 25, 2023
@squell squell added this to the Milestone 2 milestone May 31, 2023
@pvdrz pvdrz linked a pull request Jun 22, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-compliant used to track failing compliance tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants