-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle signal stop and continue #520
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Number of dependencies and binary size impact report
Dependencies diff └─ sudo-rs [v0.1.0-dev.20230620]
├─ glob [v0.3.1]
├─ libc [v0.2.146]
├─ log [v0.4.19]
├─ signal-hook [v0.3.15]
| ├─ libc [v0.2.146]
| ├─ signal-hook-registry [v1.4.1]
| | └─ libc [v0.2.146]
| └─ cc [v1.0.79]
└─ signal-hook-registry [v1.4.1] |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
- Coverage 86.35% 85.61% -0.75%
==========================================
Files 57 59 +2
Lines 7412 7834 +422
==========================================
+ Hits 6401 6707 +306
- Misses 1011 1127 +116
☔ View full report in Codecov by Sentry. |
This was
linked to
issues
Jun 22, 2023
3 tasks
rnijveld
approved these changes
Jun 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes done on this pull request
This PR allows sudo to properly handle stopping and continuing when receiving signals.
I think this is easier to review commit-per-commit.
This is the last chunk of #363 and it is blocked by #519.
Pull Request Checklist
sudo-rs
does not set the terminal foreground process group #360 where a proper discussion about a solution has taken place.