Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

Replace Viper config with the local structure #227

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Conversation

tzununbekov
Copy link
Member

@tzununbekov tzununbekov commented Jan 18, 2023

Viper config replaced with local pkg/config module. This approach provides more flexibility in control over configuration structure, upgrade process, and readability.
Additionally, Redis broker parameters support was added and the default broker version was switched from the static latest to the current latest (according to github releases page) to avoid unwanted upgrades.

Broker's image parameter is replaced with the version for consistency; configuration attributes will identify which broker to use, eg:

context: bar
triggermesh:
    version: v1.23.0
    broker:
        version: v1.0.0
        redis:
            address: 127.0.0.1:6666
            username: foo
            password: bar
            skip-verify: true

-redis broker v1.0.0 will be used

context: foo
triggermesh:
    version: v1.23.0
    broker:
        version: v1.1.0
        memory:
            buffer-size: "100"
            produce-timeout: 1s

-default configuration with in-memory broker

Related to #87.

@tzununbekov tzununbekov self-assigned this Jan 18, 2023
@tzununbekov tzununbekov force-pushed the config-struct branch 8 times, most recently from 8ee411b to 680384c Compare January 23, 2023 07:59
@tzununbekov tzununbekov marked this pull request as ready for review January 23, 2023 08:24
@tzununbekov tzununbekov merged commit 1a98ad0 into main Jan 23, 2023
@tzununbekov tzununbekov deleted the config-struct branch January 23, 2023 08:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant