Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: WalletConnect integration, part 7, sign #2276

Merged
merged 2 commits into from
Jan 3, 2025
Merged

feat: WalletConnect integration, part 7, sign #2276

merged 2 commits into from
Jan 3, 2025

Conversation

dianasavvatina
Copy link
Contributor

@dianasavvatina dianasavvatina commented Dec 17, 2024 •
edited
Loading

Proposed changes

Added payload sign for WalletConnect

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

  1. connect umami wallet via WalletConnect
  2. run test "Sign the provided payload"
  3. confirm on wallet side
  4. see that the test has passed. Scroll the output and see the provided signature.

Screenshots

Add the screenshots of how the app used to look like and how it looks now

image image

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-embed-iframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 5:28pm
umami-embed-iframe-ghostnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 5:28pm
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 5:28pm
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 5:28pm

@dianasavvatina dianasavvatina force-pushed the wc_sign branch 2 times, most recently from 5f9bb71 to 1390f8b Compare December 18, 2024 10:05
OKendigelyan
OKendigelyan approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@OKendigelyan OKendigelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with small nit 👍

apps/web/src/components/beacon/useHandleBeaconMessage.tsx
appName: message.appMetadata.name,
appIcon: message.appMetadata.icon,
payload: message.payload,
signer: signer,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signer: signer could be simplified to signer

@dianasavvatina dianasavvatina merged commit 9085d74 into main Jan 3, 2025
10 checks passed
@dianasavvatina dianasavvatina deleted the wc_sign branch January 3, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OKendigelyan OKendigelyan OKendigelyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dianasavvatina @OKendigelyan