-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use cmake presets #237
Conversation
Update README. Update vcpkg commit hash for dependencies. Fix bugs.
@elantzb I cannot mark you as a reviewer, but tagging you here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing jumps out at me as problematic. I want to try building this and see what happens on my end.
Update this to use latest c++ language standard. |
I recommend updating the description on the PR/commit to be more verbose. For the sake of a paper trail if needed in the future. |
This will require protocolbuffers/protobuf#10232 to be merged into a new version and the the version needs to be put on VCPKG and the baseline commit hash needs to be updated. |
Fix include in pxiel-buffer.cpp being nested under tec namespace. The compiler was errantly looking for tec::std::man because of this. Add launch confing for vscode. Properly set c++17 via target_compile_features interface to propagate
Change build images
Add visual studio launch.vs.json. Fix tests not being found and properly link gtest libs.
Update build preset descriptions to be a bit less pedantic.
Remove no longer relevant selene include from CMakeLists. Add VS_DEBUGGER_WORKING_DIRECTORY to client and server CMakeLists to define the desired working directory.
Visual studio 2017 is not supported any longer it appears due to sol2 ThePhD/sol2#1362 |
Fix documentation warnings.
Prior run was successful and the final commit should have skipped run as it was a typo fix to the README. I am going to merge this via admin powers instead of waiting. |
Change to use CMake presets and update documentation generation, and the README, along side various bug fixes.
Description
Update README and added docs generation targets.
Fix readthedoc setup by including python requirements.
Update vcpkg commit hash for dependencies.
Change to use CMake presets with ninja multi config.
Fix asset failing to load missing null pointer check for animation.cpp.
Some adjustments to fmt.
Fix Dead ImGUI root window id being empty.
Add EOL find utility for md5anim and obj parsing. This should be replaced by a better check @elantzb .
Add better validation to md5anim parsing.
Remove explicit default constructor for Mesh.hpp Vertex
Update CMake min version to 19.
Fix include in pxiel-buffer.cpp being nested under tec namespace.
The compiler was errantly looking for tec::std::man because of this.
Add launch config for vscode.
Properly set c++17 via target_compile_features interface to propagate
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: