Fixes #54 - Apply connection configuration #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorint
force-pushed
the
apply_connection_configuration
branch
from
1ed4d3b
to
1764b9e
Compare
lorint
force-pushed
the
apply_connection_configuration
branch
from
1764b9e
to
b654761
Compare
bensheldon
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pursuant to issue #54 identified by @tmimura39 regarding applying connection configuration. Tomohiko indicates:
As such, here is a fix which strives to adhere as closely as possible to how connection configuration behaviour is implemented in Rails 7.1.