correct reference to materialize_transactions in with_trilogy_connection #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inside the method we need to be explicit that we are calling `materialize_transactions` the method and not `materialize_transactions` the keyword argument.
|
cc @bensheldon & @lorint |
|
gentle bump @bensheldon, anything I might be missing to merge this ? |
|
Thank you for the PR! This fix has been released: https://github.com/trilogy-libraries/activerecord-trilogy-adapter/releases/tag/v3.1.2 |
|
@dhruvCW - Thank you very much for helping to make Trilogy everything that it is. For the encouragement early-on some months ago when these things were forming. For your continued involvement. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inside the method we need to be explicit that we are calling
materialize_transactionsthe method and notmaterialize_transactionsthe keyword argument.this fixes #60