Expose #connection_options
on the Ruby binding.
#48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes a
#connection_options
method on the Ruby binding, allowing users to query the client for the options passed in at connect time. This is meant to be similar to Mysql2's#query_options
.We're currently using
Mysql2::Client#query_options
in a couple of places in our Rails apps at Shopify, and there's no equivalent in Trilogy -- we could go through the connection pool and grab thedb_config
instead, but it's nice to be able to access connection options on the client IMHO. It also facilitates other use cases, like being able to configure span name for MySQL instrumentation with OpenTelemetry (just as is being done for Mysql2).As an aside: I've noticed that there are a couple of places (e.g. benchmark script, docs) where we reference a non-existent
#query_options
method. I'm wondering if this was removed from the API at some point? Is there any value to bringing that back in addition to#connection_options
? If not, I can remove those references to avoid confusion 😄