Set error_code on Trilogy::TimeoutError
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileencodes
approved these changes
Apr 19, 2023
eileencodes
added a commit
to eileencodes/rails
that referenced
this pull request
Apr 20, 2023
Until we do a new release we need to run against main on trilogy to get the latest changes from trilogy-libraries/trilogy#69
eileencodes
added a commit
to rails/rails
that referenced
this pull request
Apr 21, 2023
Until we do a new release we need to run against main on trilogy to get the latest changes from trilogy-libraries/trilogy#69
danielvdao
pushed a commit
to danielvdao/rails
that referenced
this pull request
May 1, 2023
Until we do a new release we need to run against main on trilogy to get the latest changes from trilogy-libraries/trilogy#69
danielvdao
pushed a commit
to danielvdao/rails
that referenced
this pull request
May 1, 2023
Until we do a new release we need to run against main on trilogy to get the latest changes from trilogy-libraries/trilogy#69
danielvdao
pushed a commit
to danielvdao/rails
that referenced
this pull request
May 1, 2023
Until we do a new release we need to run against main on trilogy to get the latest changes from trilogy-libraries/trilogy#69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mistakenly removed the constructor that sets
error_codeonTrilogy::TimeoutErrorin #63. I thought that since it was a syscall error, we'd never set an error code on timeout errs, but we do raise aTimeoutErrorwith an error code here.