fix(log): Expensive DEBUG log always run (#470) #471
Conversation
Don't run expensive JSON serialization for `DEBUG` logging unless that level would be printed/emitted. Fixes trim21#470
|
I don't see how this change could have caused the docs failure? |
not your fault |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
transmission_rpc/client.py
Dismissed
| @@ -275,7 +275,9 @@ | |||
| "failed to parse response as json", method=method, argument=arguments, rawResponse=http_data | |||
| ) from error | |||
|
|
|||
| self.logger.debug(json.dumps(data, indent=2)) | |||
| if self.logger.isEnabledFor(logging.DEBUG): | |||
| self.logger.debug(json.dumps(data, indent=2)) | |||
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
There was a problem hiding this comment.
Pre-existing issue, right?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #471 +/- ##
==========================================
- Coverage 77.67% 77.62% -0.06%
==========================================
Files 14 14
Lines 1505 1506 +1
==========================================
Hits 1169 1169
- Misses 336 337 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Don't run expensive JSON serialization for
DEBUGlogging unless that level would be printed/emitted.Fixes #470